Missing <td> element in permission admin page

[Jun Omae]

327             <tr class="even">
328               <td>user</td>
329               <td>
330                 <label>
331                   <!--! base64 makes it safe to use ':' as separator when passing
332                       both subject and action as one query parameter -->
333                   <span title="PERMISSION_GRANT">PERMISSION_GRANT</span>
334                 </label>
335               </td>
336             </tr>
337             <tr>        <===
338             </tr>       <===
339           </tbody>

Minor thing, we could remove many <!--! base64 makes it safe to use ... comment from rendered page.

315                 <label>
316                   <!--! base64 makes it safe to use ':' as separator when passing
317                       both subject and action as one query parameter -->
318                   <span title="WIKI_CREATE">WIKI_CREATE</span>
319                 </label>
320                 <label>
321                   <!--! base64 makes it safe to use ':' as separator when passing
322                       both subject and action as one query parameter -->
323                   <span title="WIKI_MODIFY">WIKI_MODIFY</span>
324                 </label>
325               </td>
326             </tr>

[Ryan J Ollos]

Proposed change:

trac/admin/templates/admin_perms.html

@@ -136 +136 @@
                 <label>
                   #   set invalid = action not in actions
                   #   set has_perm = action in perm
-                  <!--! base64 makes it safe to use ':' as separator when passing
-                      both subject and action as one query parameter -->
                   #   if can_revoke:
                   <input type="checkbox" name="sel"
                          class="trac-disable-determinant"
@@ -155 +153 @@
               </td>
             </tr>
             # endfor
+            # if not perms:
             <tr>
-              # if not perms:
               <td colspan="2">${_("No permissions")}</td>
-              # endif
             </tr>
+            # endif
           </tbody>
         </table>
 
@@ -175 +173 @@
               <td>
                 # for subject in group_subjects:
                 <label>
-                  <!--! base64 makes it safe to use ':' as separator when passing
-                      both subject and action as one query parameter -->
                   # if can_revoke:
                   <input type="checkbox" name="sel"
                          class="trac-disable-determinant"

[Ryan J Ollos]

Committed to 1.4-stable in r17297, merged in r17298.

[Ryan J Ollos]

Fixed another instance of empty tr in r17364, merged in r17365.