Duplicated id="repoindex" in repository browser page

[Jun Omae]

$ curl -s 'https://trac.edgewall.org/browser' | grep 'repoindex'
      <h1 id="repoindex">Repository Index</h1>
<table class="listing dirlist"  id="repoindex">

[Ryan J Ollos]

The h1 doesn't have id="repoindex" on 1.2-stable. It's since r15461.

Proposed change:

trac/htdocs/css/browser.css

@@ -18 +18 @@
 h1 .first:link, h1 .first:visited { color: #998 }
 h1 .sep { color: #666; padding: 0 .1em }
 h1 .pathentry { float: left; padding: 0 .1em }
-h1#repoindex { margin-top: 1em; }
+h1.repoindex { margin-top: 1em; }
 
 #diffrev, #jumprev, #jumploc {
  float: right;

trac/versioncontrol/templates/browser.html

@@ -290 +290 @@
       # endif
 
       # if repo and repo.repositories:
-      <h1 id="repoindex">${_("Repository Index")}</h1>
+      <h1 class="repoindex">${_("Repository Index")}</h1>
       #   with repoindex = 'repoindex'
       #     include 'repository_index.html'
       #   endwith

[Ryan J Ollos]

Committed to 1.4-stable in r17330, merged to trunk in r17331.

[Ryan J Ollos]

Also there's empty id elements in ticket change history when attachment added:

<div class="change" id="">

trac/ticket/templates/ticket.html

@@ -209 +209 @@
           #   set change_date = change['comment_history'][latest]['date']
           <div class="${classes('change',
                       'trac-new' if change_date is greaterthan(start_time) and
-                      'attachment' not in change.fields)}"
-               id="${'trac-change-%d-%d' % (
-                   change.cnum,
-                   to_utimestamp(change.date)) if 'cnum' in change}">
+                      'attachment' not in change.fields)}"${
+             {'id': 'trac-change-%d-%d' % (change.cnum, to_utimestamp(change.date))
+                    if 'cnum' in change}|htmlattr}>
             # include 'ticket_change.html'
           </div>
           # endfor

[Ryan J Ollos]

Table summary attribute is deprecated in HTML5:

trac/templates/progress_bar_grouped.html

@@ -13 +13 @@
 Arguments:
  - groups: a list of group data dicts
  - grouped_by: ticket field by which tickets are grouped
- - summary: table summary text
 #}
-  <table${{'summary': summary if summary is defined}|htmlattr}>
+  <table>
     # for group in groups:
     #   set obfuscated = is_obfuscated(format_author(group.name))
     <tr>

trac/ticket/templates/milestone_view.html

@@ -82 +82 @@
               });
             </script>
           </legend>
-          # with summary = _('Shows the milestone completion status grouped by %(grouped_by)s', grouped_by=grouped_by)
-          #   if groups:
-          #     include 'progress_bar_grouped.html' ignore missing
-          #   endif
-          # endwith
+          # if groups:
+          #   include 'progress_bar_grouped.html' ignore missing
+          # endif
         </fieldset>
       </form>
       # endif

[Ryan J Ollos]

comment:4 change committed to 1.4-stable in r17366, merged to trunk in r17367.

[Ryan J Ollos]

comment:5 change committed to 1.4-stable in r17368, merged to trunk in r17369.