Edgewall Software
Modify

Opened 2 months ago

Closed 8 weeks ago

Last modified 8 weeks ago

#13237 closed defect (worksforme)

Trac Genshi support working at all?

Reported by: Dirk Stöcker Owned by:
Priority: normal Milestone:
Component: general Version: 1.4
Severity: major Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

I tried to update an Trac instance from 1.2.x to 1.4 and now iniadminpanel plugin fails completely. I e.g. get "TemplateSyntaxError: unexpected char u'&' at 10166" from the Jinja code, whereas the template is genshi.

That I get Jinja errors for a Genshi template seems highly suspicious. I tried fixing them and only get more and more issues.

Attachments (0)

Change History (6)

comment:1 by anonymous, 2 months ago

Confirm all panels return '*.html', data, None instead of return '*.html', data (wiki:TracDev/PortingFromGenshiToJinja#PanelProviders / r15459).

Maybe a note can be added to wiki:TracDev/ApiChanges/1.3#Genshioptionaldeprecated

comment:2 by Dirk Stöcker, 2 months ago

That's incompatible to previous Trac versions, so the plugin fails for Trac < 1.4 which also means that any plugin with admin panels must be updated to work with Trac 1.4. The whole idea of remaining Genshi support was that this is not the case.

comment:3 by anonymous, 2 months ago

To support old and new Trac needs code like this

comment:4 by Dirk Stöcker, 2 months ago

Genshi support also lacks support for updated TracInterfaceCustomization. The site_head.html is not applied for Genshi template. You still need to use the old-style stuff, but as far as I see that's nowhere documented, at least not in the documentation page.

comment:5 by Ryan J Ollos, 8 weeks ago

Resolution: worksforme
Status: newclosed

in reply to:  4 comment:6 by Ryan J Ollos, 8 weeks ago

Replying to Dirk Stöcker:

Genshi support also lacks support for updated TracInterfaceCustomization. The site_head.html is not applied for Genshi template. You still need to use the old-style stuff, but as far as I see that's nowhere documented, at least not in the documentation page.

#12681

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.