Edgewall Software
Modify

Opened 20 years ago

Closed 19 years ago

#1323 closed defect (duplicate)

Trac produces invalidly marked-up URLs in links

Reported by: anonymous Owned by: Jonas Borgström
Priority: normal Milestone:
Component: general Version: devel
Severity: normal Keywords: invalid xhtml entities
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The URLs in the roadmap page contain ampersands, but fail to be encoded as & entities.

For example, the link for viewing closed tickets on Trac's 0.8.2 milestone is sent as …href="/trac/query?status=closed&milestone=0.8.2"… when it should be sent as …href="/trac/query?status=closed&milestone=0.8.2"

Encoding the ampersands in URLs is necessary for valid XHTML and fixing it won't cause problems for any browsers, even though most are smart enough to deal with this bit of invalid markup. Also, this error is currently preventing Trac from serving with a content-type of application/xhtml+xml (Firefox craps out on this error and won't show the page).

For more information, see Ampersands (&'s) in URLs. For confirmation that this is happening, run the roadmap page through W3C's validator.

I'm afraid I don't know enough about Trac's internals to know if the generation of invalidly marked-up URLs is specific to the Roadmap function, but that's the page that is giving this error.

Attachments (0)

Change History (4)

comment:1 by anonymous, 20 years ago

Component: roadmapgeneral
Owner: changed from Christopher Lenz to Jonas Borgström

These same un-marked-up URLs exist on the browser page as well, so I'm moving this from roadmap to general.

W3C Validation of browser

comment:2 by anonymous, 20 years ago

Summary: Roadmap page has invalid markupTrac produces invalidly marked-up URLs in links

comment:3 by Mark Rowe, 20 years ago

Two instances fixed in [1397].

comment:4 by Christopher Lenz, 19 years ago

Resolution: duplicate
Status: newclosed

Duplicate of #2042 which has been fixed in [2273].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.