Opened 19 years ago
Closed 19 years ago
#2042 closed defect (fixed)
& characters in query: links are escaped twice
Reported by: | Matthew Good | Owned by: | Christian Boos |
---|---|---|---|
Priority: | high | Milestone: | 0.9 |
Component: | general | Version: | 0.9b1 |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
The & characters in query: links (possibly others, but I haven't tested this yet) are escaped twice to: &
Attachments (1)
Change History (6)
comment:1 by , 19 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Version: | 0.8.4 → 0.9b1 |
comment:2 by , 19 years ago
Oops, sorry, just looked closer to ticket #1927 and learnt that ampersands in URIs should be escaped…
I'll replace the patch soon.
by , 19 years ago
Attachment: | 2042-fix.patch added |
---|
Fixes query: and search: links. Takes into account #1927.
comment:3 by , 19 years ago
Priority: | normal → high |
---|
That patch also fixes the query: links which start without "?".
Before, a Query.from_string
was done on an already escaped string,
therefore the split on "&" produced an incorrect field name
(e.g. query:milestone=1.0&owner=me
was transformed in amp;owner=me&milestone=1.0
).
comment:4 by , 19 years ago
cboos, I've tested this patch and it looks good. Can you please check it in?
I noticed that too while working on the
search:
links, and I fixed it for the search, but not for the query: