Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

#2042 closed defect (fixed)

& characters in query: links are escaped twice

Reported by: Matthew Good Owned by: Christian Boos
Priority: high Milestone: 0.9
Component: general Version: 0.9b1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

The & characters in query: links (possibly others, but I haven't tested this yet) are escaped twice to: &

Attachments (1)

2042-fix.patch (3.6 KB ) - added by Christian Boos 14 years ago.
Fixes query: and search: links. Takes into account #1927.

Download all attachments as: .zip

Change History (6)

comment:1 by Christian Boos, 14 years ago

Owner: changed from Matthew Good to Christian Boos
Status: newassigned
Version: 0.8.40.9b1

I noticed that too while working on the search: links, and I fixed it for the search, but not for the query:

comment:2 by Christian Boos, 14 years ago

Oops, sorry, just looked closer to ticket #1927 and learnt that ampersands in URIs should be escaped

I'll replace the patch soon.

by Christian Boos, 14 years ago

Attachment: 2042-fix.patch added

Fixes query: and search: links. Takes into account #1927.

comment:3 by Christian Boos, 14 years ago

Priority: normalhigh

That patch also fixes the query: links which start without "?". Before, a Query.from_string was done on an already escaped string, therefore the split on "&" produced an incorrect field name (e.g. query:milestone=1.0&owner=me was transformed in amp;owner=me&milestone=1.0).

comment:4 by Christopher Lenz, 14 years ago

cboos, I've tested this patch and it looks good. Can you please check it in?

comment:5 by Christian Boos, 14 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in r2273.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.