Link tags in RSS feed mangled on Trac 1.3.6

[niels.reedijk@…]

When this plugin is enabled, the RSS feed is malformed, in that the link tags are botched. See ​our timeline RSS feed for an example.

We are using the trunk module, revision r17015.

[Jun Omae]

Work around:

tracspamfilter/filters/trapfield.py

@@ -90 +90 @@
 
     # ITemplateStreamFilter interface
     def filter_stream(self, req, method, filename, stream, data):
+        if method != 'html':
+            return stream
         if self.karma_points > 0:
             # Insert the hidden field right before the submit buttons
             trap = tag.div(style='display:none;')(

I think the plugin for 1.4-stable should be created.

[Ryan J Ollos]

Added plugins/1.4/spam-filter​.

[Jun Omae]

Root cause is that Trac core uses genshi.input.HTML to generate a genshi.core.Stream instance for an XML content. Instead, we should use genshi.input.XML for.

trac/web/chrome.py

@@ -38 +38 @@
 if genshi:
     from genshi.core import Attrs, START
     from genshi.filters import Translator
-    from genshi.input import HTML
+    from genshi.input import HTML, XML
     from genshi.output import DocType
     from genshi.template import TemplateLoader, MarkupTemplate, NewTextTemplate
 
@@ -1938 +1938 @@
         def _filter_jinja_page(self, req, content, method, filename,
                                content_type, data, fragment, iterable):
             doctype = self.html_doctype if content_type == 'text/html' else None
-            stream = HTML(content)
+            stream = HTML(content) if method != 'xml' else XML(content)
             stream |= self._filter_stream(req, method, filename, data)
             if fragment:
                 return stream

TODO

• Add unit tests.
• Check the behavior of _filter_jinja_page() for text templates.

[Jun Omae]

Proposed changes in [1a7bcfad7/jomae.git] (jomae.git@t13196+1.4).

[Ryan J Ollos]

Changes look good to me.

[Jun Omae]

Thanks for the reviewing. Committed in [17145].