Modify ↓
#13195 closed defect (fixed)
Problem with macros that load CSS / JS
| Reported by: | anonymous | Owned by: | Jun Omae |
|---|---|---|---|
| Priority: | highest | Milestone: | 1.5.1 |
| Component: | rendering | Version: | |
| Severity: | normal | Keywords: | jinja2 |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: |
Fixed regressions in r17093. |
||
Description
There seems to be a problem in after r17093:
To reproduce create a ticket or wiki page containing a macro that loads additional CSS or Javascript, for example [[RepositoryIndex(format=table)]].
Before the change this loads CSS to show folder icons and so on. After the change it does not. Other macros that load JS also don't work anymore.
Attachments (0)
Change History (10)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
| Keywords: | jinja2 added |
|---|---|
| Milestone: | → 1.5.1 |
comment:3 by , 5 years ago
| Priority: | normal → highest |
|---|
Regression that breaks built-in functionality.
comment:4 by , 5 years ago
[[Workflow]] is another built-in macro broken by this. The Javascript does not get loaded.
comment:5 by , 5 years ago
Proposed changes in [999f08f55/jomae.git] (jomae.git@t13195), with unit tests.
comment:8 by , 5 years ago
| Owner: | set to |
|---|---|
| Release Notes: | modified (diff) |
| Status: | new → assigned |
Committed in [17123].
comment:9 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:10 by , 5 years ago
Note:
See TracTickets
for help on using tickets.
It seems the problem is that these lines were deleted in r17093. Were they maybe removed by mistake? Or the simpler way hinted at in the comment was not added, or is not working?