Context Navigation

Modify ↓

#13176 closed defect (fixed)

Skip custom field of type select with no options

Reported by:	Ryan J Ollos	Owned by:	Ryan J Ollos
Priority:	low	Milestone:	1.0.18
Component:	ticket system	Version:
Severity:	normal	Keywords:	ticket-custom
Cc:		Branch:
Release Notes:	Select custom field is not created if it has no `options`.
API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

Ticket custom field with no options is created as an empty select:

[ticket-custom]
...
select1 = select
...

I found strange behavior resulted in ticket validation when testing #13040. A warning would be raised when cloning a ticket, but not when creating a new ticket.

I think it would be better to just skip creation of ticket custom field of type select when it has no options.

trac/ticket/api.py

diff --git a/trac/ticket/api.py b/trac/ticket/api.py
index 9a752c32f..4c29f7c80 100644

                class TicketSystem(Component):
+            }
             if field['type'] == 'select' or field['type'] == 'radio':
                 field['options'] = config.getlist(name + '.options', sep='|')
+                if not field['options']:
+                    continue
                 if '' in field['options']:
                     field['optional'] = True
                     field['options'].remove('')

The built-in ticket fields already have this behavior .

Attachments (1)

Screen Shot 2019-07-03 at 12.32.01.jpg (20.1 KB ) - added by Ryan J Ollos 6 years ago.

Download all attachments as: .zip

Change History (4)

by Ryan J Ollos, 6 years ago

Attachment:	Screen Shot 2019-07-03 at 12.32.01.jpg added

comment:1 by Ryan J Ollos, 6 years ago

Description:	modified (diff)

comment:2 by Ryan J Ollos, 6 years ago

Proposed changes in log:rjollos.git:t13176_select_without_options.

comment:3 by Ryan J Ollos, 6 years ago

Release Notes:	modified (diff)
Resolution:	→ fixed
Status:	assigned → closed

Committed to 1.0-stable in r16937, merged in r16938, r16939.

Modify Ticket

Change Properties

Summary:
Description:	Ticket custom field with no options is created as an empty select: {{{#!ini [ticket-custom] ... select1 = select ... }}} [[Image("Screen Shot 2019-07-03 at 12.32.01.jpg", 50%)]] I found strange behavior resulted in ticket validation when testing #13040. A warning would be raised when cloning a ticket, but not when creating a new ticket. I think it would be better to just skip creation of ticket custom field of type select when it has no options. {{{#!diff diff --git a/trac/ticket/api.py b/trac/ticket/api.py index 9a752c32f..4c29f7c80 100644 --- a/trac/ticket/api.py +++ b/trac/ticket/api.py @@ -379,6 +379,8 @@ class TicketSystem(Component): } if field['type'] == 'select' or field['type'] == 'radio': field['options'] = config.getlist(name + '.options', sep='\|') + if not field['options']: + continue if '' in field['options']: field['optional'] = True field['options'].remove('') }}} The built-in ticket fields [browser:tags/trac-1.0.17/trac/ticket/api.py@:321-324#L319 already have this behavior]. You may use WikiFormatting here.
Type:		Priority:
Milestone:		Component:
Version:		Severity:
Keywords:		Cc:	Set your email in Preferences
Branch:
Release Notes:	Select custom field is not created if it has no `options`.
API Changes:
Internal Changes:

Action

leave as closed The owner will remain Ryan J Ollos.

reopen The resolution will be deleted. Next status will be 'reopened'.

change ownership to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.

Download in other formats: