Add video renderer in Trac core

[Jun Omae]

Trac is able to render an image file but not a video file. I'd like to add the following component to trac/mimeview/api.py.

class VideoRenderer(Component):

    implements(IHTMLPreviewRenderer)

    def get_quality_ratio(self, mimetype):
        if mimetype.startswith('video/'):
            return 8
        return 0

    def render(self, context, mimetype, content, filename=None, url=None):
        if url:
            return tag.div(tag.video(src=url, alt=filename, type=mimetype,
                                     controls='controls'),
                           class_='video-file')

[Ryan J Ollos]

Good idea.

[Christian Boos]

Replying to Ryan J Ollos:

Good idea.

+1

So what about your ​TH:MovieMacro? Was there anything more there that would still make it relevant for the HTML5 version of Trac? If so, anything that can be ported over on top of your <video> suggestion?

(well, obviously we'd need to add at least a proper Video macro to render the above tag)

[Ryan J Ollos]

Moving forward since we'll be releasing soon. Please feel free to move back if you'd like to include the change in 1.2.5 within the next few days.

[Ryan J Ollos]

Milestone renamed