Edgewall Software

Opened 5 years ago

Last modified 5 years ago

#13116 closed enhancement

A few stylistic improvements (#12640) — at Version 5

Reported by: Christian Boos Owned by: Christian Boos
Priority: normal Milestone: 1.3.4
Component: general Version: 1.3dev
Severity: normal Keywords: pullrequest css
Cc: Branch: log:cboos.git@t12640-refinement.5
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

I had these changes locally for almost a year (and a half)…

Finally getting around to commit them, but as it's been a long time, I'd like to ask for a code review.

[OT] what about a new "pull request" ticket type?

Change History (5)

comment:1 by Jun Omae, 5 years ago

In comment:27:ticket:633 and comment:29:ticket:633, I've suggested that font-size of root element should be fixed (14px). The fixed font-size is conflicted with changes for unit length in the proposed changes. Please check the changes with the fixed font-size.

Last edited 5 years ago by Jun Omae (previous) (diff)

in reply to:  description ; comment:2 by Ryan J Ollos, 5 years ago

Replying to Christian Boos:

[OT] what about a new "pull request" ticket type?

Or we could use a keyword, since "pull request" and task/defect/enhancement are not mutually exclusive.

comment:3 by Ryan J Ollos, 5 years ago

Proposed changes look good to me.

in reply to:  2 comment:4 by Christian Boos, 5 years ago

Keywords: pullrequest added

Replying to Ryan J Ollos:

Replying to Christian Boos:

[OT] what about a new "pull request" ticket type?

Or we could use a keyword, since "pull request" and task/defect/enhancement are not mutually exclusive.

Well, I suggested a ticket type as I was thinking about type-specific workflow, type-specific fields and type-specific presentation… I ought to know that this is not yet possible ;-) So in the meantime, sure, a keyword would do!

comment:5 by Christian Boos, 5 years ago

Branch: log:cboos.git@t12640-refinement.5
Description: modified (diff)
Owner: set to Christian Boos
Status: newassigned
Note: See TracTickets for help on using tickets.