Edgewall Software
Modify ↓

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#13114 closed defect (fixed)

CSS problem with overlapping quoted bullets

Reported by: anonymous Owned by: Christian Boos
Priority: normal Milestone: 1.2.4
Component: wiki system Version:
Severity: normal Keywords: css
Cc: Branch:
Release Notes:

Fixed margins around quoted lines containing bullet points.

API Changes:
Internal Changes:

Description

Quoted bullets use negative margins CSS, example: 

* ABCDEFABCDEFABCDEF
> * ABCDEFABCDEFABCDEF

Is rendered with overlapping text lines:

  • ABCDEFABCDEFABCDEF
    • ABCDEFABCDEFABCDEF

Attachments (0)

Change History (9)

comment:1 by anonymous, 6 years ago

Previously reported in #13113, which disappeared?

comment:2 by Jun Omae, 6 years ago

Keywords: css added
Milestone: → next-stable-1.2.x

Ad hoc patch is here. The style is introduced in r3364.

  • trac/htdocs/css/trac.css 

    diff --git a/trac/htdocs/css/trac.css b/trac/htdocs/css/trac.css
index 491815c94..adac09fdf 100644
    a b tt {  
    550550}
    551551
    552552blockquote.citation {
    553  margin: -0.6em 0;
     553 margin: 0;
    554554 border-style: solid;
    555555 border-width: 0 0 0 2px;
    556556 padding-left: .5em;

comment:3 by anonymous, 6 years ago

That fixes the problem, thanks.

comment:4 by anonymous, 6 years ago

Other combinations don't require the fix: 

ABCDEFABCDEFABCDEF
> ABCDEFABCDEFABCDEF


* ABCDEFABCDEFABCDEF
> ABCDEFABCDEFABCDEF

ABCDEFABCDEFABCDEF
> * ABCDEFABCDEFABCDEF

* ABCDEFABCDEFABCDEF
> * ABCDEFABCDEFABCDEF

ABCDEFABCDEFABCDEF

ABCDEFABCDEFABCDEF

  • ABCDEFABCDEFABCDEF

    ABCDEFABCDEFABCDEF

ABCDEFABCDEFABCDEF

  • ABCDEFABCDEFABCDEF
  • ABCDEFABCDEFABCDEF
    • ABCDEFABCDEFABCDEF

Do you know why?

in reply to:  2 ; comment:5 by Christian Boos, 6 years ago

Replying to Jun Omae:

Ad hoc patch is here.

This will also expand the spacing in all other situations (comment:4), including the gap between the "Replying to …" line and the quoted text (Ad hoc patch is here in this comment), which was the primary reason for that negative margin, IIRC.

An alternative fix would be: 

li blockquote.citation {
    margin-top: 0;
}

in reply to:  5 comment:6 by Jun Omae, 6 years ago

Milestone: next-stable-1.2.x → 1.2.4
Owner: set to Jun Omae
Status: new → assigned

Replying to Christian Boos:

An alternative fix would be: […]

Okay. I think we should apply your patch rather than my patch.

comment:7 by Christian Boos, 6 years ago

Owner: changed from Jun Omae to Christian Boos

I'll do that.

comment:8 by Christian Boos, 6 years ago

Resolution: → fixed
Status: assigned → closed

Applied in r16875 on 1.2-stable and merged in trunk in r16876.

comment:9 by Ryan J Ollos, 5 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.