TracAdmin hotcopy fails with InnoDB backend

[Ryan J Ollos]

Discussed in ​gmessage:trac-users:G3c4SoOVOZU/Ca_fpdq9BgAJ. The proposed change is:

trac/db/mysql_backend.py

@@ -240 +240 @@
         db_params = db_prop.setdefault('params', {}) 
         db_name = os.path.basename(db_prop['path']) 
 
-        args = [self.mysqldump_path, '--no-defaults'] 
+        defaults_opt = '--no-defaults' 
+        args = [] 
         if 'host' in db_prop: 
             args.extend(['-h', db_prop['host']]) 
         if 'port' in db_prop: 
@@ -252 +253 @@
                 args.append('--compress') 
             elif name == 'named_pipe' and as_int(value, 0): 
                 args.append('--protocol=pipe') 
-            elif name == 'read_default_file':  # Must be first 
-                args.insert(1, '--defaults-file=' + value) 
+            elif name == 'read_default_file': 
+                defaults_opt = '--defaults-file=' + value 
             elif name == 'unix_socket': 
                 args.extend(['--protocol=socket', '--socket=' + value]) 
             elif name not in ('init_command', 'read_default_group'): 
                 self.log.warning("Invalid connection string parameter '%s'", 
                                  name) 
-        args.extend(['-r', dest_file, db_name]) 
+        args = [self.mysqldump_path, defaults_opt, '--single-transaction', 
+                '--quick'] + args + ['-r', dest_file, db_name] 
 
         environ = os.environ.copy() 
         if 'password' in db_prop:

[Ryan J Ollos]

Please move back to 1.0.20 if you wish to fix for release 1.0.20 (#13294).

[Ryan J Ollos]

Milestone renamed