Edgewall Software

Opened 4 years ago

Closed 4 years ago

#13057 closed enhancement (fixed)

Unify use of 'removal'

Reported by: figaro Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.4
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Replaced term deleted in ticket property changes with removed, in order to unify terminology.

API Changes:
Internal Changes:


At some points the term 'removed' is used and at others 'deleted'. Can the parlance on screen be unified to show 'removed' only?

Potentially a similar issue applies to not only users on tickets, but also milestones, attachments and even javascript code.

Attachments (1)

Screenshot 2018-07-08 at 20.57.30.png (25.0 KB ) - added by figaro 4 years ago.
Example of use of both 'removed' and 'deleted'.

Download all attachments as: .zip

Change History (3)

by figaro, 4 years ago

Example of use of both 'removed' and 'deleted'.

comment:1 by Ryan J Ollos, 4 years ago

Component: generalticket system
Milestone: 1.3.4
Owner: set to Ryan J Ollos
Status: newassigned

The change is fine with me. With a related change we can reduce the number of translatable strings by one. If others agree, will do in milestone:1.3.4.

  • trac/ticket/web_ui.py

    commit c1656ace6056a52e795a31b73d4726eb3a2fc291
    Author: Ryan J Ollos <ryan.j.ollos@gmail.com>
    Date:   Mon Jul 9 12:50:45 2018 -0700
        Use common parlance
    diff --git a/trac/ticket/web_ui.py b/trac/ticket/web_ui.py
    index 8e25dc8c0..f4aec622a 100644
    a b class TicketModule(Component):  
    17741774                elt_renderer = lambda e: e
    17751775            added = [elt_renderer(x) for x in new_list if x not in old_list]
    17761776            remvd = [elt_renderer(x) for x in old_list if x not in new_list]
    1777             added = added and tagn_("%(items)s added", "%(items)s added",
     1777            added = added and tagn_("%(value)s added", "%(value)s added",
    17781778                                    len(added),
    1779                                     items=separated(added, separator))
    1780             remvd = remvd and tagn_("%(items)s removed", "%(items)s removed",
     1779                                    value=separated(added, separator))
     1780            remvd = remvd and tagn_("%(value)s removed", "%(value)s removed",
    17811781                                    len(remvd),
    1782                                     items=separated(remvd, separator))
     1782                                    value=separated(remvd, separator))
    17831783            if added or remvd:
    17841784                return tag(added, added and remvd and _("; "), remvd)
    class TicketModule(Component):  
    18081808            old_author = authorinfo(old)
    18091809            new_author = authorinfo(new)
    18101810            if old and not new:
    1811                 rendered = tag_("%(value)s deleted", value=old_author)
     1811                rendered = tag_("%(value)s removed", value=old_author)
    18121812            elif new and not old:
    18131813                rendered = tag_("set to %(value)s", value=new_author)
    18141814            else:  # old and new:

comment:2 by Ryan J Ollos, 4 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to trunk in r16755, new extraction in r16756.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.