Release Trac 1.0.18

[Ryan J Ollos]

This ticket is used to coordinate the finalization and testing of the next stable version of Trac, 1.0.18.

[Ryan J Ollos]

I'd like to release 1.0.18 after we finish just a few tickets, in order to test deployment to PyPI (#12833).

[Ryan J Ollos]

PyPI generates a SHA256 hash (see ​pypi:Trac/1.2.2/#files), so I propose we generate SHA256 rather than SHA1 for the next release. This will require a minor change to update-latest.sh and the LatestRelease macro (TracDownload).

[Ryan J Ollos]

pip 18.0 has been released. Travis CI fails due to use of format=legacy. I'm testing the following change:

.travis.yml

@@ -47 +47 @@
     {
       echo "[global]"
       echo "cache-dir = $HOME/.cache/pip"
-      echo "[list]"
-      echo "format = legacy"
     } >"$HOME/.pip/pip.conf"
   - |
     if [ "$TRAVIS_OS_NAME" = osx ]; then

[Ryan J Ollos]

Better patch, I think:

.travis.yml

@@ -48 +48 @@
       echo "[global]"
       echo "cache-dir = $HOME/.cache/pip"
       echo "[list]"
-      echo "format = legacy"
+      echo "format = columns"
     } >"$HOME/.pip/pip.conf"
   - |
     if [ "$TRAVIS_OS_NAME" = osx ]; then

[Ryan J Ollos]

Committed comment:4 patch to 1.0-stable in r16758, merged in r16759, r16760.

[Ryan J Ollos]

Replying to Ryan J Ollos:

PyPI generates a SHA256 hash (see ​pypi:Trac/1.2.2/#files), so I propose we generate SHA256 rather than SHA1 for the next release. This will require a minor change to update-latest.sh and the LatestRelease macro (TracDownload).

These changes have been implemented for Trac 1.0.17, 1.2.3 and 1.3.3. See TracDownload.

[Ryan J Ollos]

The Makefile gives me an error on Windows (using the Make distribution suggested in comment:7:ticket:12630):

>make checksum version=1.2.4.dev0
"Packages for Trac-1.2.4.dev0:"
ECHO is off.
f0376b038b471592b5fdef7e441444f7 *dist/Trac-1.2.4.dev0.win32.exe
Traceback (most recent call last):
  File "contrib/checksum.py", line 38, in <module>
    sys.exit(main() or 0)
  File "contrib/checksum.py", line 29, in main
    with io.open(filename, 'rb') as f:
IOError: [Errno 2] No such file or directory: 'dist/Trac-1.2.4.dev0.win-amd64.exe;'
make: *** [Makefile:662: checksum] Error 1

The following change resolves the issue and doesn't cause a problem for OSX:

Makefile

@@ -681 +681 @@
        @echo "Packages for Trac-$(version):"
        @echo
        @$(if $(packages), \
-           python contrib/checksum.py md5:sha1 $(packages); \
+           python contrib/checksum.py md5:sha1 $(packages) \
        , \
            echo "No packages found: $(sdist+wheel) $(wininst)" \
        )

[Ryan J Ollos]

Modified make checksum to address comment:6 and comment:7 in r16787, merged in r16788 and r16789.

[Ryan J Ollos]

I've tried using different distributions of make, including the suggestion in comment:7:ticket:12630. More recently, I've installed make on Windows 10 via choco install make. In each case, make checksum version=... and make release succeed, but make upload version=... fails:

> make upload version=1.2.4.dev0
"Packages for Trac-1.2.4.dev0:"
ECHO is off.
89f5ac66907d3b55c211a83d343c5a4d *dist/Trac-1.2.4.dev0.win32.exe
5c508f61d6131642ffc747bb7e2c68a2 *dist/Trac-1.2.4.dev0.win-amd64.exe
08b4645f4f80a9dc1e5a93ac52275116293d3692884a9f4786d72778bd02cd53 *dist/Trac-1.2.4.dev0.win32.exe
23d2789846379661460f3fd5580f488c0bd10b7e74c1f4682f3ea5c5e33881ce *dist/Trac-1.2.4.dev0.win-amd64.exe
C:/WINDOWS/System32/OpenSSH/scp.exe -i C:/Users/rjollos/Documents/Workspace/trac-dev/id_rsa dist/Trac-1.2.4.dev0.win32.exe dist/Trac-1.2.4.dev0.win-amd64.exe rjollos@lynx.edgewall.com:/home/rjollos/dist
process_begin: CreateProcess(NULL, C:/WINDOWS/System32/OpenSSH/scp.exe -i C:/Users/rjollos/Documents/Workspace/trac-dev/id_rsa dist/Trac-1.2.4.dev0.win32.exe dist/Trac-1.2.4.dev0.win-amd64.exe rjollos@lynx.edgewall.com:/home/rjollos/dist, ...) failed.
make (e=2): The system cannot find the file specified.
make: *** [upload] Error 2

The strange thing is that it works to run the same command in the shell: C:/WINDOWS/System32/OpenSSH/scp.exe -i C:/Users/rjollos/Documents/Workspace/trac-dev/id_rsa dist/Trac-1.2.4.dev0.win32.exe dist/Trac-1.2.4.dev0.win-amd64.exe rjollos@lynx.edgewall.com:/home/rjollos/dist.

So there is some syntax or other problem with running that command from the Makefile.

[Jun Omae]

I have the same issue on Windows 10 with C:/WINDOWS/System32/OpenSSH/scp.exe. Instead, pscp.exe (scp of PuTTY) works fine.

[Ryan J Ollos]

PuTTY works for me too. Thanks!

Documented in TracDev/ReleaseChecklist@131.

[Ryan J Ollos]

Added new update-help Makefile rule in [16796:16798]. Revised TracDev/ReleaseChecklist@133.

[Jun Omae]

Replying to Ryan J Ollos:

Added new update-help Makefile rule in [16796:16798]. Revised TracDev/ReleaseChecklist@133.

$(PYTHON) variable is introduced for Python interpreter in r14624 for 1.2-stable. We could use the variable in 1.2-stable and trunk.

        @echo "Packages for Trac-$(version):"
        @echo
        @$(if $(packages), \
-           python contrib/checksum.py md5:sha256 $(packages) \
+           $(PYTHON) contrib/checksum.py md5:sha256 $(packages) \
        , \
            echo "No packages found: $(sdist+wheel) $(wininst)" \
        )
 endif

 update-help:
-       @python contrib/checkwiki.py -d --prefix=$(prefix)
-       @python contrib/wiki2rst.py TracUpgrade > UPGRADE.rst
-       @python contrib/wiki2rst.py TracInstall > INSTALL.rst
+       @$(PYTHON) contrib/checkwiki.py -d --prefix=$(prefix)
+       @$(PYTHON) contrib/wiki2rst.py TracUpgrade > UPGRADE.rst
+       @$(PYTHON) contrib/wiki2rst.py TracInstall > INSTALL.rst

[Ryan J Ollos]

Refactoring in r16799.

comment:13 changes committed in r16800, r16803.

[Ryan J Ollos]

I'm aiming to complete #13087 and release on Saturday 02/16.

[Ryan J Ollos]

Replying to Ryan J Ollos:

I'm aiming to complete #13087 and release on Saturday 02/16.

Missed on that date, but aiming to complete this coming weekend.

[Ryan J Ollos]

I'm finding some more free time now, so if we can get all the remaining tickets closed out I will try to get the releases done.

[Ryan J Ollos]

I was going to release today, but #13087 needs to be resolved. I'll post proposed changes for that ticket today and plan to release next weekend. Please try to commit any proposed changes by end of week.

[Ryan J Ollos]

I'll make the release on Friday 7/12, or Sunday 7/14 at the latest.