Edgewall Software
Modify

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#12630 closed task (fixed)

Release Trac 1.3.2

Reported by: Christian Boos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.2
Component: general Version:
Severity: normal Keywords: release
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

This ticket is used to coordinate the finalization and testing of the next development-stable release of Trac, 1.3.2.

Attachments (0)

Change History (13)

comment:1 by Ryan J Ollos, 7 years ago

comment:2 by Ryan J Ollos, 7 years ago

comment:1 changes committed to trunk in r15585.

comment:3 by Ryan J Ollos, 7 years ago

The InvalidTicket exception is only used in one place: trunk/trac/ticket/web_ui.py@15934:1310#L1306. I think it would be appropriate to remove the exception (or at least deprecate it for removal), and replace it's use with TracValueError.

Proposed changes in [97c079318/rjollos.git].

DONE Update TracDev/Exceptions (Edited in TracDev/Exceptions@20).

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

comment:4 by Ryan J Ollos, 7 years ago

[e3f4f07aa/rjollos.git] also proposed to deprecate the unused InvalidAttachment. In #11148, we might consider adding a ResourceValidationError exception.

comment:5 by Ryan J Ollos, 7 years ago

comment:3 and comment:4 changes committed to trunk in r15943.

comment:6 by Ryan J Ollos, 7 years ago

@cboos: I've tried using the new makefile commands for releasing on Windows (r15277). I've configured Makefile.cfg with:

python.x86 = C:/Users/Ryan Ollos/Documents/Workspace/trac-release/pve-x86/Scripts/python.exe
python.x64 = C:/Users/Ryan Ollos/Documents/Workspace/trac-release/pve-x64/Scripts/python.exe

I'm using MinGW. How do you install Make on Windows?

I get a bad result, but maybe it's due to my MinGW install:

C:\Users\Ryan Ollos\Documents\Workspace\trac-release\trac-1.2.2>make release
make: python: Command not found
make python=x86 wininst
make[1]: Entering directory `/c/Users/Ryan Ollos/Documents/Workspace/trac-release/trac-1.2.2'
      0 [main] make 936 open_stackdumpfile: Dumping stack trace to make.exe.stackdump
make[1]: Leaving directory `/c/Users/Ryan Ollos/Documents/Workspace/trac-release/trac-1.2.2'
make python=x64 wininst
make[1]: Entering directory `/c/Users/Ryan Ollos/Documents/Workspace/trac-release/trac-1.2.2'
      0 [main] make 3848 open_stackdumpfile: Dumping stack trace to make.exe.stackdump
make[1]: Leaving directory `/c/Users/Ryan Ollos/Documents/Workspace/trac-release/trac-1.2.2'

in reply to:  6 ; comment:7 by anonymous, 7 years ago

Replying to Ryan J Ollos:

@cboos: I've tried using the new makefile commands for releasing on Windows (r15277). I've configured Makefile.cfg with:

python.x86 = C:/Users/Ryan Ollos/Documents/Workspace/trac-release/pve-x86/Scripts/python.exe
python.x64 = C:/Users/Ryan Ollos/Documents/Workspace/trac-release/pve-x64/Scripts/python.exe

I'm using MinGW. How do you install Make on Windows?

I think best is to use the builds from Eli Zaretskii, for example make-4.2.1-with-guile-w32-bin.zip.

I get a bad result, but maybe it's due to my MinGW install:

If it still doesn't work with that make.exe, try to get rid of the space characters in the path to python.exe (use dir /x "c:/Users/Ryan Ollos" in a cmd.exe shell to get the short DOS path).

in reply to:  7 comment:8 by Ryan J Ollos, 7 years ago

Replying to anonymous:

Replying to Ryan J Ollos:

@cboos: I've tried using the new makefile commands for releasing on Windows (r15277). I've configured Makefile.cfg with:

python.x86 = C:/Users/Ryan Ollos/Documents/Workspace/trac-release/pve-x86/Scripts/python.exe
python.x64 = C:/Users/Ryan Ollos/Documents/Workspace/trac-release/pve-x64/Scripts/python.exe

I'm using MinGW. How do you install Make on Windows?

I think best is to use the builds from Eli Zaretskii, for example make-4.2.1-with-guile-w32-bin.zip.

Thanks for the tips. Switching to that version of make and removing python.exe from the Makefile.cfg paths fixed the issue.

comment:9 by Ryan J Ollos, 7 years ago

Owner: set to Ryan J Ollos

I'll create the 1.3.2 release soon.

comment:10 by Ryan J Ollos, 7 years ago

I'll do the release on August 30th if all pending changes have been committed.

comment:11 by Ryan J Ollos, 7 years ago

Resolution: fixed
Status: assignedclosed

in reply to:  7 ; comment:12 by Ryan J Ollos, 6 years ago

Replying to anonymous:

Replying to Ryan J Ollos:

@cboos: I've tried using the new makefile commands for releasing on Windows (r15277). I've configured Makefile.cfg with:

python.x86 = C:/Users/Ryan Ollos/Documents/Workspace/trac-release/pve-x86/Scripts/python.exe
python.x64 = C:/Users/Ryan Ollos/Documents/Workspace/trac-release/pve-x64/Scripts/python.exe

I'm using MinGW. How do you install Make on Windows?

I think best is to use the builds from Eli Zaretskii, for example make-4.2.1-with-guile-w32-bin.zip.

I see that grep is available via grep-2.10-w32-bin.zip. We also use sed in the Makefile. Does one of those packages provide sed?

In the future I hope to to build all the packages on Windows 10 using WSL: #13064.

in reply to:  12 comment:13 by Jun Omae, 6 years ago

Replying to Ryan J Ollos:

I see that grep is available via grep-2.10-w32-bin.zip. We also use sed in the Makefile. Does one of those packages provide sed?

I think we could use https://chocolatey.org/packages/gnuwin32-sed.install (sed-4.2.1-setup.exe is launched) or manually install binaries zip from http://gnuwin32.sourceforge.net/packages/sed.htm.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.