session add command is inconsistent with user preferences when name and email are empty string

[Jun Omae]

If name and email are saved with empty string, no session_attribute records are created for name and email. However, session add and session set command with empty string create session_attribute records with empty value.

I think we should remove session_attribute records if name and email are empty.

Trac [/dev/shm/tracenv]> session list

SID  Auth  Last Visit  Name  Email
----------------------------------

Trac [/dev/shm/tracenv]> session add blah:1
Trac [/dev/shm/tracenv]> session add blah-with-empty-values:1 '' ''
Trac [/dev/shm/tracenv]> session list

SID                     Auth  Last Visit  Name  Email
-----------------------------------------------------
blah                    1     2016-12-05
blah-with-empty-values  1     2016-12-05

Trac [/dev/shm/tracenv]>

$ sqlite3 /dev/shm/tracenv/db/trac.db
SQLite version 3.8.2 2013-12-06 14:53:30
Enter ".help" for instructions
Enter SQL statements terminated with a ";"
sqlite> .nullvalue <NULL>
sqlite> SELECT NULL;
<NULL>
sqlite> .header on
sqlite> .mode column
sqlite> SELECT * FROM session_attribute;
sid                     authenticated  name        value
----------------------  -------------  ----------  ----------
blah-with-empty-values  1              name
blah-with-empty-values  1              email

[Jun Omae]

Proposed changes in [ee9679355/jomae.git].

[Ryan J Ollos]

Changes look good to me.

[Jun Omae]

Thanks. Committed in [15293] and merged in [15294-15295].