Wrong error message on start after update from 1.2 to 1.2.2

[Dirk Stöcker]

Hi, I updated our trac from 1.2 to 1.2.2 and get following start message:

Trac[authz_policy] WARNING: The action !WIKI_MODIFY in the [wiki:...] section of fineperm.conf is not a valid action.

based on the line:

* = !WIKI_MODIFY

in fineperm.conf

Actually the line still works correctly, so I assume some sanity check does not properly recognize the "!" syntax.

[Jun Omae]

Thanks for the reporting! It seems that is regression of #12734.

tracopt/perm/authz_policy.py

@@ -204 +204 @@
         for group, users in groups.iteritems():
             add_items('@' + group, users)
 
-        all_actions = PermissionSystem(self.env).get_actions()
+        all_actions = set(PermissionSystem(self.env).get_actions())
+        authz_basename = os.path.basename(self.authz_file)
         for section in self.authz.sections():
             if section == 'groups':
                 continue
             for _, actions in self.authz.items(section):
                 for action in to_list(actions):
+                    if action.startswith('!'):
+                        action = action[1:]
                     if action not in all_actions:
                         self.log.warning("The action %s in the [%s] section "
                                          "of %s is not a valid action.",
-                                         action, section,
-                                         os.path.basename(self.authz_file))
+                                         action, section, authz_basename)
 
     def normalise_resource(self, resource):
         def to_descriptor(resource):

Also, we should add unit tests with !ACTION. Missing tests for that.

[Ryan J Ollos]

Committed the comment:1 patch in r16336, merged to trunk in r16337.

Proposed additions to test coverage in [2556a86ad/rjollos.git]. This is targeted to trunk since we have a mock logger that captures messages in-memory.

[Ryan J Ollos]

comment:2 changes committed to trunk in r16343.