Opened 7 years ago
Last modified 7 years ago
#12890 closed defect
Remove fieldsets which have had iefix class — at Version 4
| Reported by: | Jun Omae | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.2.3 |
| Component: | general | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: |
Removed unintended |
||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
fieldset.iefix has been added in [979] to avoid some old IE bugs. The fieldset element wraps textarea element for wikitext but is not visible. The fieldset.iefix has no borders, no margins and no padding.
The fieldset.iefix has been removed and iefix class has been removed from fieldset elements in [11129] but fieldsets still remains. Then, the fieldset element became to be visible because fieldset rule in trac.css is applied.
Trac 1.0 and later:
Trac 0.12 and early:
But I think it is unintentional, and that is not cool.
I consider we should remove the fieldset elements which wrap textarea.wikitext because fieldset.iefix is not available.
Change History (9)
by , 7 years ago
| Attachment: | fieldset.png added |
|---|
by , 7 years ago
| Attachment: | fieldset-0.12.png added |
|---|
comment:1 by , 7 years ago
| Description: | modified (diff) |
|---|
by , 7 years ago
| Attachment: | Screen Shot 2017-08-11 at 01.51.59.png added |
|---|
comment:3 by , 7 years ago
| Owner: | set to |
|---|---|
| Release Notes: | modified (diff) |
| Status: | new → assigned |
comment:4 by , 7 years ago
| Release Notes: | modified (diff) |
|---|
by , 7 years ago
| Attachment: | Screen Shot 2017-08-21 at 01.15.16.png added |
|---|
by , 7 years ago
| Attachment: | Screen Shot 2017-08-21 at 01.18.32.png added |
|---|
Note:
See TracTickets
for help on using tickets.
Removing the fieldset looks good to me. On trunk at least, for
label.trac-textarea-hintI would also setline-heightto100%andmargin-bottomto0.5em. Or do some other tweaks that add more space below the You may use WikiFormatting here and move it closer to thetextarea.