Edgewall Software
Modify

Opened 2 years ago

Closed 2 years ago

#12874 closed defect (fixed)

Button to switch interactive/plain-text view doesn't work if preferred language is non-English

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.3.2
Component: i18n Version: 1.3dev
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fix switch to plain-text/interactive mode in error.html when preferred language is not English.

API Changes:

Description

Because this.value.indexOf("interactive") < 0 doesn't work as expected if preferred language is non-English, at trunk/trac/templates/error.html@15964:39,40,45#L38:

Line 
38 $("#tbtoggle").click(function() {
39 if (this.value.indexOf("interactive") < 0) {
40 this.value = j_("Switch to interactive view");
41 $("#traceback ul").fadeOut("fast", function() {
42 $("#traceback pre").fadeIn("fast");
43 });
44 } else {
45 this.value = j_("Switch to plain text view");
46 $("#traceback pre").fadeOut("fast", function() {
47 $("#traceback ul").fadeIn("fast");
48 });
49 }
50 return false;
51 });

Attachments (0)

Change History (4)

comment:1 by Jun Omae, 2 years ago

Owner: set to Jun Omae
Status: newassigned

Proposed changes in [9186ecf40/jomae.git] (jomae.git@t12874).

comment:2 by Jun Omae, 2 years ago

Release Notes: modified (diff)
Summary: Button to switch intractive/plain-text view doesn't work if preferred language is non-EnglishButton to switch interactive/plain-text view doesn't work if preferred language is non-English

comment:3 by Ryan J Ollos, 2 years ago

Changes look good to me.

comment:4 by Jun Omae, 2 years ago

Resolution: fixed
Status: assignedclosed

Thanks for the viewing. Committed in [16155].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.