Modify ↓
#12873 closed defect (fixed)
Remove id attributes in wiki toolbar
Reported by: | Jun Omae | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.3.3 |
Component: | wiki system | Version: | |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: |
Fixed duplicate HTML |
||
API Changes: | |||
Internal Changes: |
Description
Wiki toolbar feature is generating the following for textarea.wikitext
. The generated html has id attributes but wiki toolbars can be multiple, for example, when viewing ticket form if custom fields with wiki format are configured.
<div class="wikitoolbar"> <a href="#" id="strong" title="Bold text: **Example**" tabindex="400"></a> <a href="#" id="em" title="Italic text: ''Example''" tabindex="400"></a> <a href="#" id="heading" title="Heading: == Example" tabindex="400"></a> <a href="#" id="link" title="Link: [http://www.example.com/ Example]" tabindex="400"></a> <a href="#" id="code" title="Code block: {{{ example }}}" tabindex="400"></a> <a href="#" id="hr" title="Horizontal rule: ----" tabindex="400"></a> <a href="#" id="np" title="New paragraph" tabindex="400"></a> <a href="#" id="br" title="Line break: \\" tabindex="400"></a> <a href="#" id="img" title="Image: [[Image()]]" tabindex="400"></a> </div>
I think we should use class attributes rather than the id attributes.
Attachments (0)
Change History (5)
comment:1 by , 7 years ago
comment:3 by , 7 years ago
Release Notes: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Thanks, committed in r16178.
comment:4 by , 7 years ago
Owner: | set to |
---|
comment:5 by , 5 years ago
Release Notes: | modified (diff) |
---|
Note:
See TracTickets
for help on using tickets.
Proposed changes in [4548a9822/rjollos.git].