Wrong "None bytes" in title attribute of size column in repository browser

[Jun Omae]

$ curl -s https://trac.edgewall.org/demo-1.0/browser | grep -F 'title="None'
        <span title="None bytes"></span>
        <span title="None bytes"></span>
        <span title="None bytes"></span>
        <span title="None bytes"></span>
        <span title="None bytes"></span>

trac/versioncontrol/templates/dir_entries.html

@@ -25 +25 @@
                                 order=order if order != 'name' else None, desc=desc)}">$entry.name</a>
       </td>
       <td class="size">
-        <span title="${_('%(size)s bytes', size=entry.content_length)}">${pretty_size(entry.content_length)}</span>
+        <span py:if="entry.content_length is not None"
+              title="${_('%(size)s bytes', size=entry.content_length)}">${
+          pretty_size(entry.content_length)}</span>
         <a py:if="entry.raw_href" href="$entry.raw_href" class="${'trac-ziplink' if isdir else 'trac-rawlink'}"
            title="${_('Download as Zip archive') if isdir else _('Download')}">&#8203;</a>
       </td>

[Jun Omae]

The same issue existed in trunk with Jinja2 template. It has been fixed in [16135/trunk/trac/versioncontrol/templates/dir_entries.html].

[Jun Omae]

Proposed changes with unit tests in [3a4b957f3/jomae.git].

[Ryan J Ollos]

Looks good to me.

[Jun Omae]

Thanks. Committed in [16206].