Edgewall Software
Modify

Opened 2 years ago

Closed 2 years ago

#12863 closed defect (fixed)

Cannot translate "%(radio)s Show" in diff_options.html

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.3.2
Component: i18n Version: 1.3dev
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

The following html is in source:/trunk/trac/templates/diff_options.html@15484:36,39#L24:

<label>
  <input type="radio" name="contextall" value="0" checked="checked"/>
  Show
</label>
<label>
  <input type="text" name="contextlines" id="contextlines" size=" maxlength=" value="2"/>
  lines around each change
</label>

%(radio)s Show and %(text)s lines around each change are extracted as separated messages. I cannot translate those messages due to separating.

I'd like to be extracted one message:

  • trac/templates/diff_options.html

    diff --git a/trac/templates/diff_options.html b/trac/templates/diff_options.html
    index d798b2ee0..6c007abe3 100644
    a b Arguments:  
    2323</select>
    2424<div class="field">
    2525  # set input_radio
    26   <input type="radio" name="contextall" value="0"
     26  <input id="contextall-0" type="radio" name="contextall" value="0"
    2727         ${{"checked": not diff.options.contextall}|htmlattr}/>
    2828  # endset
    2929  # set input_text
    Arguments:  
    3232         value="${'all' if diff.options.contextlines is lessthan(0) else
    3333                diff.options.contextlines}"/>
    3434  # endset
    35   # set n_context_lines
    36   <label>${tag_("%(text)s lines around each change", text=input_text)}</label>
    37   # endset
    38   # set radio_button_show
    39   <label>${tag_("%(radio)s Show", radio=input_radio)}</label>
    40   # endset
    41   # trans radio_button_show, n_context_lines
    42 
    43   ${radio_button_show} ${n_context_lines}
    44 
    45   # endtrans
     35  <label for="contextall-0">
     36    ${tag_("%(radio)s Show %(text)s lines around each change",
     37           radio=input_radio, text=input_text)}
     38  </label>
    4639  <br/>
    4740  <label><input type="radio" name="contextall" value="1"
    4841                ${{"checked": diff.options.contextall}|htmlattr}/>

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 2 years ago

I'd like to do the 1.3.2 release this weekend. Would it be possible to push the fix in the next day or so?

comment:2 by Jun Omae, 2 years ago

Owner: set to Jun Omae
Status: newassigned
Version: 1.3dev

I'm going to push the changes.

comment:3 by Jun Omae, 2 years ago

Resolution: fixed
Status: assignedclosed

Committed in [16134] revised with trans block rather than tag_.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.