Edgewall Software
Modify ↓

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#12841 closed defect (fixed)

Group heading not shown for first group in report if group is empty

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.2
Component: report system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed missing report heading in first group when value is empty

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

For example, report {3}:

The group heading with value NULL is shown when it's not the first heading:

And it works correctly when there is only one group heading that is not a NULL value:

r10384 added or (empty), but not for the first heading.

Attachments (3)

Screen Shot 2017-06-15 at 11.27.13.png​ (36.4 KB ) - added by Ryan J Ollos 7 years ago.
Screen Shot 2017-06-15 at 11.27.38.png​ (44.1 KB ) - added by Ryan J Ollos 7 years ago.
Screen Shot 2017-06-15 at 11.28.16.png​ (35.3 KB ) - added by Ryan J Ollos 7 years ago.

Download all attachments as: .zip

Change History (10)

by Ryan J Ollos, 7 years ago

Attachment: Screen Shot 2017-06-15 at 11.27.13.png​ added

by Ryan J Ollos, 7 years ago

Attachment: Screen Shot 2017-06-15 at 11.27.38.png​ added

by Ryan J Ollos, 7 years ago

Attachment: Screen Shot 2017-06-15 at 11.28.16.png​ added

comment:1 by Ryan J Ollos, 7 years ago

Description: modified (diff)

comment:2 by Ryan J Ollos, 7 years ago

One proposed change in [9f25cdfb3/rjollos.git].

When the group heading is NULL, it would be nice if Milestone (empty) was shown rather than just (empty). We could add an isnull function for each connection class and modify the reports. For example, on SQLite for report {3} we'd have: 

-   'Milestone '||milestone AS __group__,
+   'Milestone '||ifnull(milestone,'(empty)') AS __group__,

I don't think it would be worth fixing up existing reports through a database upgrade step, but we could modify the reports in the database to affect new installations and add a note to TracUpgrade about how to manually modify reports.

comment:3 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.2.x → 1.2.2

Second issue described in comment:2 will be investigated in #12848.

in reply to:  2 comment:4 by Jun Omae, 7 years ago

Replying to Ryan J Ollos:

For example, on SQLite for report {3} we'd have: 

-   'Milestone '||milestone AS __group__,
+   'Milestone '||ifnull(milestone,'(empty)') AS __group__,

If '(empty)' is embedded in the report, (empty) cannot be translated.

comment:5 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed
Summary: Group heading not shown in report if only 1 group and group is NULL → Group heading not shown for first group in report if group is empty

Committed to 1.2-stable in r16056, merged to trunk in r16057.

comment:6 by Jun Omae, 7 years ago

I think this issue still exists after r16056. If new ticket is created with milestone field selecting blank, milestone column would be NULL. 

sqlite> .nullvalue <NULL>
sqlite> .mode line
sqlite> SELECT * FROM ticket WHERE id=12;
         id = 12
       type = defect
       time = 1497878573112092
 changetime = 1497878573112092
  component = component1
   severity = <NULL>
   priority = major
      owner = <NULL>
   reporter = admin
         cc = <NULL>
    version = <NULL>
  milestone = <NULL>
     status = new
 resolution = <NULL>
    summary = tst
description = <NULL>
   keywords = <NULL>

comment:7 by Jun Omae, 7 years ago

Sorry. Please ignore it. I've fetched mirror but used old source.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.