Edgewall Software
Modify

Opened 3 years ago

Closed 3 years ago

#12831 closed defect (fixed)

pylint --include-ids and --comment options were removed in pylint 1.6

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.15
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Removed obsolete switches from pylint command in Makefile. pylint ≥ 1.6 should be used.

API Changes:
Internal Changes:

Description

The latest is pylint 1.7.1.

$ make pylint
pylint \
            --include-ids=y --persistent=n --comment=n --init-import=y \
            --disable=E0102,E0211,E0213,E0602,E0611,E1002,E1101,E1102,E1103 \
            --disable=F0401 \
            --disable=W0102,W0141,W0142,W0201,W0212,W0221,W0223,W0231,W0232, \
            --disable=W0401,W0511,W0603,W0613,W0614,W0621,W0622,W0703 \
            --disable=C0103,C0111 \
            trac tracopt
No config file found, using default configuration
Usage:  pylint [options] module_or_package

  Check that a module satisfies a coding standard (and more !).

    pylint --help

  Display this help message and exit.

    pylint --help-msg <msg-id>[,<msg-id>]

  Display help messages about given message identifiers and exit.


pylint: error: no such option: --include-ids
make: *** [pylint] Error 32

Pylint 1.5.5 issues the following warning:

Warning: option --include-ids is obsolete and it is slated for removal in Pylint 1.6.
Warning: option --comment is obsolete and it is slated for removal in Pylint 1.6.

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 3 years ago

Proposed changes remove the two obsolete options, and add the ability to run make pylint=<filename>. However, I know very little of Make, so maybe there is a better way.

  • Makefile

    diff --git a/Makefile b/Makefile
    index 0530d500e..e15f198fc 100644
    a b define HELP_code  
    332332endef
    333333export HELP_code
    334334
     335pylintopts = --persistent=n --init-import=y \
     336--disable=E0102,E0211,E0213,E0602,E0611,E1002,E1101,E1102,E1103 \
     337--disable=F0401 \
     338--disable=W0102,W0141,W0142,W0201,W0212,W0221,W0223,W0231,W0232, \
     339--disable=W0401,W0511,W0603,W0613,W0614,W0621,W0622,W0703 \
     340--disable=C0103,C0111 \
     341
     342ifdef pylint
     343all:
     344       pylint $(pylintopts) $(subst /,.,$(pylint:.py=))
     345else
    335346pylint:
    336        pylint \
    337            --include-ids=y --persistent=n --comment=n --init-import=y \
    338            --disable=E0102,E0211,E0213,E0602,E0611,E1002,E1101,E1102,E1103 \
    339            --disable=F0401 \
    340            --disable=W0102,W0141,W0142,W0201,W0212,W0221,W0223,W0231,W0232, \
    341            --disable=W0401,W0511,W0603,W0613,W0614,W0621,W0622,W0703 \
    342            --disable=C0103,C0111 \
    343            trac tracopt
     347       pylint $(pylintopts) trac tracopts
     348endif
    344349
    345350^L
    346351# ----------------------------------------------------------------------------

comment:2 by Ryan J Ollos, 3 years ago

Milestone: 1.0.141.0.15

comment:3 by Ryan J Ollos, 3 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in r16011, merged in r16012, r16013. See also #12218.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.