pylint --include-ids and --comment options were removed in pylint 1.6

[Ryan J Ollos]

The latest is pylint 1.7.1.

$ make pylint
pylint \
            --include-ids=y --persistent=n --comment=n --init-import=y \
            --disable=E0102,E0211,E0213,E0602,E0611,E1002,E1101,E1102,E1103 \
            --disable=F0401 \
            --disable=W0102,W0141,W0142,W0201,W0212,W0221,W0223,W0231,W0232, \
            --disable=W0401,W0511,W0603,W0613,W0614,W0621,W0622,W0703 \
            --disable=C0103,C0111 \
            trac tracopt
No config file found, using default configuration
Usage:  pylint [options] module_or_package

  Check that a module satisfies a coding standard (and more !).

    pylint --help

  Display this help message and exit.

    pylint --help-msg <msg-id>[,<msg-id>]

  Display help messages about given message identifiers and exit.


pylint: error: no such option: --include-ids
make: *** [pylint] Error 32

Pylint 1.5.5 issues the following warning:

Warning: option --include-ids is obsolete and it is slated for removal in Pylint 1.6.
Warning: option --comment is obsolete and it is slated for removal in Pylint 1.6.

[Ryan J Ollos]

Proposed changes remove the two obsolete options, and add the ability to run make pylint=<filename>. However, I know very little of Make, so maybe there is a better way.

Makefile

@@ -332 +332 @@
 endef
 export HELP_code
 
+pylintopts = --persistent=n --init-import=y \
+--disable=E0102,E0211,E0213,E0602,E0611,E1002,E1101,E1102,E1103 \
+--disable=F0401 \
+--disable=W0102,W0141,W0142,W0201,W0212,W0221,W0223,W0231,W0232, \
+--disable=W0401,W0511,W0603,W0613,W0614,W0621,W0622,W0703 \
+--disable=C0103,C0111 \
+
+ifdef pylint
+all:
+       pylint $(pylintopts) $(subst /,.,$(pylint:.py=))
+else
 pylint:
-       pylint \
-           --include-ids=y --persistent=n --comment=n --init-import=y \
-           --disable=E0102,E0211,E0213,E0602,E0611,E1002,E1101,E1102,E1103 \
-           --disable=F0401 \
-           --disable=W0102,W0141,W0142,W0201,W0212,W0221,W0223,W0231,W0232, \
-           --disable=W0401,W0511,W0603,W0613,W0614,W0621,W0622,W0703 \
-           --disable=C0103,C0111 \
-           trac tracopt
+       pylint $(pylintopts) trac tracopts
+endif
 
 ^L
 # ----------------------------------------------------------------------------

[Ryan J Ollos]

Committed to 1.0-stable in r16011, merged in r16012, r16013. See also #12218.