Log resource name for macro and processor errors

[Ryan J Ollos]

Currently the resource realm and id are not logged. Example:

2017-05-24 15:20:24,905 Trac[formatter] ERROR: Macro SiblingPage(None) failed:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/trac/wiki/formatter.py", line 765, in _macro_formatter
    return macro.ensure_inline(macro.process(args))
  File "/usr/lib/python2.7/site-packages/trac/wiki/formatter.py", line 356, in process
    text = self.processor(text)
  File "/usr/lib/python2.7/site-packages/trac/wiki/formatter.py", line 340, in _macro_processor
    text, self.args)
  File "build/bdist.linux-x86_64/egg/neighborpage/nav.py", line 76, in expand_macro
    prefix = '/' in page and page[:page.rindex('/') + 1] or ''
TypeError: argument of type 'NoneType' is not iterable

[Ryan J Ollos]

Proposed change:

trac/wiki/formatter.py

@@ -794 +794 @@
         except MacroError, e:
             return system_message(e)
         except Exception, e:
-            self.env.log.error('Macro %s(%s) failed:%s', name, args,
+            self.env.log.error("Macro %s(%s) failed in %s:%s:%s", name,
+                               args, self.resource.realm, self.resource.id,
                                exception_to_unicode(e, traceback=True))
             return system_message(_("Error: Macro %(name)s(%(args)s) failed",
                                     name=name, args=args), to_unicode(e))
@@ -1187 +1188 @@
         try:
             return processor.process(text)
         except Exception, e:
-            self.env.log.error('Processor %s failed:%s', processor.name,
+            self.env.log.error("Processor %s failed in %s:%s:%s",
+                               processor.name, self.resource.realm,
+                               self.resource.id,
                                exception_to_unicode(e, traceback=True))
             return system_message(_("Error: Processor %(name)s failed",
                                     name=processor.name), to_unicode(e))

[Ryan J Ollos]

Committed to 1.0-stable in r15944, merged to 1.2-stable in r15945, merged to trunk r15946.