post_process_request no longer redirects after exception handling

[Ryan J Ollos]

Prior to Trac 1.2, a redirect in post_process_request during exception handling would succeed because RequestDone was re-raised​.

r14604 attempted to simplify the complex nested exception handling. RequestDone is no longer re-raised​.

The issue was discovered in ​#13185.

[Ryan J Ollos]

Proposed fix:

trac/web/main.py

@@ -270 +270 @@
             try:
                 self._post_process_request(req)
             except RequestDone:
-                pass
+                raise
             except TracError as e2:
                 self.log.warning("Exception caught while post-processing"
                                  " request: %s", exception_to_unicode(e2))

I'll look at adding a regression test that redirects in post_process_request during exception handling. Is there any other case in which RequestDone would be raised by post_process_request?

[Ryan J Ollos]

Committed to 1.2-stable in r15953, merged to trunk in r15954.