to_list should return empty list on falsy input

[Ryan J Ollos]

It would be nice if to_list returned an empty list on falsy input, so that short statements like to_list(req.args.get('key')) could be used without altering the default arg of None.

trac/util/__init__.py

@@ -1307 +1307 @@
 def to_list(splittable, sep=','):
     """Split a string at `sep` and return a list without any empty items.
     """
+    if not splittable:
+        return []
     split = [x.strip() for x in splittable.split(sep)]
     return [item for item in split if item]

>>> from trac.util import to_list
>>> to_list([])
[]
>>> to_list(None)
[]
>>> to_list('')
[]

[Ryan J Ollos]

Committed to 1.2-stable in r15781, merged in r15782.