TracError while post-processing leads noisy logging

[Jun Omae]

TracError while executing process_request() is logged with WARNING level and no traceback. However, same exception while post-processing is logged with ERROR level and traceback. That's noisy….

See ​https://groups.google.com/d/msg/trac-users/4tVRBotYrZs/NB3ZjUYjCAAJ ​googlegroups:trac-users:4tVRBotYrZs/NB3ZjUYjCAAJ.

trac/web/main.py

@@ -280 +280 @@
                 except RequestDone:
                     raise
                 except Exception, e:
-                    self.log.error("Exception caught while post-processing"
-                                   " request: %s",
-                                   exception_to_unicode(e, traceback=True))
+                    self.log.error(
+                        "Exception caught while post-processing request: %s",
+                        exception_to_unicode(
+                            e, traceback=not isinstance(TracError, e)))
                 raise err[0], err[1], err[2]
         except PermissionError, e:
             raise HTTPForbidden(e)