TracIni macro should have a way to specify exact section and option names to render

[Jun Omae]

[[TracIni(notification)]] and [[TracIni(notification-subscriber)]] are used in TracNotification page. However, [notification-subscriber] section is rendered twice.

It is caused by [[TracIni(notification)]] rendering both notification and notification-subscriber sections. I think it is intend to render only notification section.

Then, the macro should have a way to specify exact section and option names to render, e.g.:

• [[TracIni(section=notification)]]: render notification section
• [[TracIni(section=notification-*)]]: render sections matched notification-* pattern
• [[TracIni(option=smtp_enabled)]]: render smtp_enabled options in any sections
• [[TracIni(option=smtp_*)]]: render options matched smtp_* pattern in any sections
• [[TracIni(section=notification,option=mime_encoding)]]: render [notification] mime_encoding

[Ryan J Ollos]

Good idea. See also #9401.

[Jun Omae]

I noticed an issue that document of all sections and matched options are rendered. I think it is intended to render sections which include matched options and the options.

E.g. [[TracIni(,smtp_enabled)]] should render only [notification] section and smtp_enabled option. However, all sections are rendered.

[Jun Omae]

Proposed changes in [f69828124/jomae.git].

[Ryan J Ollos]

I noticed that glob matching is done for the ordered argument. Both produce the same output:

• [[TracIni(,option=max_*_size)]]
• [[TracIni(,max_*_size)]]

Is that the desired behavior, or should [[TracIni(,max_*_size)]] only match an option named max_*_size?

It's unfortunate that the macro was originally implemented to match names starting with the specified section and option. The macro would have been better if it was originally implemented to do glob matching. Given the existing behavior, I think the choices you made are the best we can do while preserving backward compatibility.

[Jun Omae]

Thanks for the reviewing. Revised changes in [63798ea90/jomae.git]. The ordered arguments don't glob matching.

[Ryan J Ollos]

Changes look good to me.

[Jun Omae]

Thanks, again. Committed in [15296] and merged in [15297].

[Jun Omae]

Normalizing keywords.