Edgewall Software

Opened 7 years ago

Last modified 7 years ago

#12621 closed defect

Edit button in milestone view should have accesskey="e" attribute — at Version 3

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.14
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Add accesskey="e" to edit button in milestone page.

API Changes:
Internal Changes:

Description

Edit buttons in wiki view and report view pages have accesskey="e" attribute however edit button in milestone view doesn't have.

  • trac/ticket/templates/milestone_view.html 

    diff --git a/trac/ticket/templates/milestone_view.html b/trac/ticket/templates/milestone_view.html
index 7b7393116..2ef253a89 100644
    a b  
    8989        <form py:if="'MILESTONE_MODIFY' in perm(milestone.resource)" method="get" action="" id="editmilestone">
    9090          <div>
    9191            <input type="hidden" name="action" value="edit" />
    92             <input type="submit" value="${_('Edit milestone')}" />
     92            <input type="submit" value="${_('Edit milestone')}" accesskey="e" />
    9393          </div>
    9494        </form>
    9595        <form py:if="'MILESTONE_DELETE' in perm(milestone.resource)" method="get" action="" id="deletemilestone">

Change History (3)

comment:1 by Ryan J Ollos, 7 years ago

Since it's a very simple change, maybe we should commit on 1.0-stable before 1.0.14?

comment:2 by Jun Omae, 7 years ago

Milestone: 1.2.1 → 1.0.14
Owner: set to Jun Omae
Status: new → assigned

Sounds good. I'm going to push it on 1.0-stable.

comment:3 by Jun Omae, 7 years ago

Release Notes: modified (diff)

Committed in [15273] and merged in [15274-15275].

Note: See TracTickets for help on using tickets.