Modify ↓
Opened 8 years ago
Closed 8 years ago
#12621 closed defect (fixed)
Edit button in milestone view should have accesskey="e" attribute
Reported by: | Jun Omae | Owned by: | Jun Omae |
---|---|---|---|
Priority: | normal | Milestone: | 1.0.14 |
Component: | ticket system | Version: | |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: |
Add |
||
API Changes: | |||
Internal Changes: |
Description
Edit buttons in wiki view and report view pages have accesskey="e"
attribute however edit button in milestone view doesn't have.
-
trac/ticket/templates/milestone_view.html
diff --git a/trac/ticket/templates/milestone_view.html b/trac/ticket/templates/milestone_view.html index 7b7393116..2ef253a89 100644
a b 89 89 <form py:if="'MILESTONE_MODIFY' in perm(milestone.resource)" method="get" action="" id="editmilestone"> 90 90 <div> 91 91 <input type="hidden" name="action" value="edit" /> 92 <input type="submit" value="${_('Edit milestone')}" />92 <input type="submit" value="${_('Edit milestone')}" accesskey="e" /> 93 93 </div> 94 94 </form> 95 95 <form py:if="'MILESTONE_DELETE' in perm(milestone.resource)" method="get" action="" id="deletemilestone">
Attachments (0)
Change History (4)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
Milestone: | 1.2.1 → 1.0.14 |
---|---|
Owner: | set to |
Status: | new → assigned |
Sounds good. I'm going to push it on 1.0-stable.
comment:3 by , 8 years ago
Release Notes: | modified (diff) |
---|
Committed in [15273] and merged in [15274-15275].
comment:4 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Since it's a very simple change, maybe we should commit on 1.0-stable before 1.0.14?