Edgewall Software

Opened 5 years ago

Closed 5 years ago

#12621 closed defect (fixed)

Edit button in milestone view should have accesskey="e" attribute

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.14
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Add accesskey="e" to edit button in milestone page.

API Changes:
Internal Changes:


Edit buttons in wiki view and report view pages have accesskey="e" attribute however edit button in milestone view doesn't have.

  • trac/ticket/templates/milestone_view.html

    diff --git a/trac/ticket/templates/milestone_view.html b/trac/ticket/templates/milestone_view.html
    index 7b7393116..2ef253a89 100644
    a b  
    8989        <form py:if="'MILESTONE_MODIFY' in perm(milestone.resource)" method="get" action="" id="editmilestone">
    9090          <div>
    9191            <input type="hidden" name="action" value="edit" />
    92             <input type="submit" value="${_('Edit milestone')}" />
     92            <input type="submit" value="${_('Edit milestone')}" accesskey="e" />
    9393          </div>
    9494        </form>
    9595        <form py:if="'MILESTONE_DELETE' in perm(milestone.resource)" method="get" action="" id="deletemilestone">

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 5 years ago

Since it's a very simple change, maybe we should commit on 1.0-stable before 1.0.14?

comment:2 by Jun Omae, 5 years ago

Owner: set to Jun Omae
Status: newassigned

Sounds good. I'm going to push it on 1.0-stable.

comment:3 by Jun Omae, 5 years ago

Release Notes: modified (diff)

Committed in [15273] and merged in [15274-15275].

comment:4 by Jun Omae, 5 years ago

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.