EnvironmentStub.upgrade fails for in-memory SQLite database

[Ryan J Ollos]

Discussed in ​gmessage:trac-dev:Ri1Xj1HBNms/2gME805cCQAJ. I didn't explore the issue in detail, but it appears that an effective workaround is to not close the database for in-memory SQLite:

trac/env.py

@@ -822 +822 @@
             with self.db_transaction as db:
                 participant.upgrade_environment(db)
             # Database schema may have changed, so close all connections
-            DatabaseManager(self).shutdown()
+            dbm = DatabaseManager(self)
+            if dbm.connection_uri != 'sqlite::memory:':
+                dbm.shutdown()
         del self.database_version
         return True

However, it needs to be explored further before any definite conclusions are drawn.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12618. I had hoped to avoid putting the comparison dbm.connection_uri != 'sqlite::memory:' directly in env.py, but I don't see another good way.

[Ryan J Ollos]

Committed to 1.2-stable in r15288, merged to trunk in r15289.