Edgewall Software
Modify ↓

Opened 9 years ago

Closed 9 years ago

#12515 closed defect (fixed)

add_notice/add_warning redundantly escape for Markup instances

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.12
Component: rendering Version: 1.0-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Avoid redundant escaping for a Markup instance in add_notice/add_warning.

API Changes:
Internal Changes:

Description

Passing a Markup instance to add_notice/add_warning method, the methods redundantly escapes the instance. 

        add_notice(req, Markup("<b>42</b>"))

I think we shouldn't escape Markup instances in add_notice/add_warning.

Attachments (1)

add-notice-with-markup.png​ (4.7 KB ) - added by Jun Omae 9 years ago.

Download all attachments as: .zip

Change History (4)

by Jun Omae, 9 years ago

Attachment: add-notice-with-markup.png​ added

comment:1 by Jun Omae, 9 years ago

Milestone: next-stable-1.0.x → 1.0.12
Owner: set to Jun Omae
Status: new → assigned

Proposed changes in jomae.git@t12515.

comment:2 by Ryan J Ollos, 9 years ago

That looks good. Appears to be same issue encountered in ​th:#12722.

Last edited 9 years ago by Jun Omae (previous) (diff)

in reply to:  2 comment:3 by Jun Omae, 9 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Replying to Ryan J Ollos:

That looks good. Appears to be same issue encountered in ​th:#12722.

Thanks for the review. I noticed this issue while creating patch which is posted in comment:25:ticket:4309.

Committed in [14847] and merged to trunk in [14848] with minor changes (s/tag(Markup(/tag(/).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.