Timezone of MercurialChangeset's date is wrong

[Jun Omae]

$ TZ=America/St_Johns date +'%x %X %z'
04/12/2016 01:58:26 PM -0230
$ TZ=America/St_Johns hg add test.txt
$ TZ=America/St_Johns hg commit -m 'half-hour timezone'
$ hg log -r 0
changeset:   0:ffda17928997
tag:         tip
user:        Jun Omae <jun66j5@gmail.com>
date:        Tue Apr 12 13:58:55 2016 -0230
summary:     half-hour timezone
$
$ ~/venv/trac/1.0.10/bin/python
Python 2.5.6 (r256:88840, Oct 21 2014, 22:49:55)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from trac.env import Environment
>>> env = Environment('/home/jun66j5/var/trac/1.0-sqlite')
>>> repos = env.get_repository('test.hg')
>>> cset = repos.get_changeset(0)
>>> cset.date
datetime.datetime(2016, 4, 12, 18, 58, 55, tzinfo=<FixedOffset "GMT 2:00" 2:30:00>)

The timezone offset should be -2:30.

[Jun Omae]

tracext/hg/backend.py

@@ -594 +594 @@
 
     def from_hg_time(self, timeinfo):
         time, tz = timeinfo
-        tzinfo = FixedOffset(tz / 60, 'GMT %d:00' % (tz / 3600))
+        tz = -tz
+        tzmin = tz / 60
+        if tz == 0:
+            name = 'GMT'
+        else:
+            name = 'GMT ' + ('+' if tz >= 0 else '-') + \
+                   '%02d:%02d' % divmod(abs(tzmin), 60)
+        tzinfo = FixedOffset(tzmin, name)
         return datetime.fromtimestamp(time, tzinfo)
 
     def changectx(self, rev=None):

After the above patch, the date property would be the same with date field in hg log -r0.

>>> cset = repos.get_changeset(0)
>>> cset.date
datetime.datetime(2016, 4, 12, 13, 58, 55, tzinfo=<FixedOffset "GMT -02:30" -1 day, 21:30:00>)
>>> cset.date.isoformat()
'2016-04-12T13:58:55-02:30'
>>>

[Peter Suter]

Pushed comment:1 changes with test in [57/mercurial-plugin].