Edgewall Software
Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12448 closed defect (fixed)

Test failure on Windows when crypt or passlib is not installed

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.11
Component: web frontend Version:
Severity: normal Keywords: tests
Cc: Branch:
Release Notes:

Fixed test failures on Windows when fcrypt (Trac 1.0) or passlib (Trac 1.2) were not installed.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

On 1.0-stable:

(pve) C:\Users\Ryan Ollos\Documents\Workspace\Trac\trac-1.0-stable>python trac/w
eb/tests/auth.py
SKIP: fine-grained permission tests (ConfigObj not installed)
.............Warning: cannot parse password for user "crypt" without the "crypt"
 module
FWarning: cannot parse password for user "crypt" without the "crypt" module
.Warning: cannot parse password for user "crypt" without the "crypt" module
.
======================================================================
FAIL: test_crypt (__main__.BasicAuthenticationTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "trac/web/tests/auth.py", line 208, in test_crypt
    self.assertTrue(self.auth.test('crypt', 'crypt'))
AssertionError: False is not true

----------------------------------------------------------------------
Ran 16 tests in 0.078s

FAILED (failures=1)

On trunk:

(pve) C:\Users\Ryan Ollos\Documents\Workspace\Trac\trac-trunk>python trac/web/te
sts/auth.py
.............Warning: cannot parse password for user "crypt" without the "crypt"
 module. Install the passlib package from PyPI
FWarning: cannot parse password for user "crypt" without the "crypt" module. Ins
tall the passlib package from PyPI
.Warning: cannot parse password for user "crypt" without the "crypt" module. Ins
tall the passlib package from PyPI
.
======================================================================
FAIL: test_crypt (__main__.BasicAuthenticationTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "trac/web/tests/auth.py", line 159, in test_crypt
    self.assertTrue(self.auth.test('crypt', 'crypt'))
AssertionError: False is not true

----------------------------------------------------------------------
Ran 16 tests in 0.093s

FAILED (failures=1)

Attachments (2)

t12248_1.0-stable.diff (2.3 KB ) - added by Ryan J Ollos 4 years ago.
t12248_trunk.diff (724 bytes ) - added by Ryan J Ollos 4 years ago.

Download all attachments as: .zip

Change History (7)

by Ryan J Ollos, 4 years ago

Attachment: t12248_1.0-stable.diff added

by Ryan J Ollos, 4 years ago

Attachment: t12248_trunk.diff added

comment:2 by Jun Omae, 4 years ago

Looks good to me.

comment:3 by Ryan J Ollos, 4 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Thanks for review. Committed to 1.0-stable in [14709], merged to trunk in [14710].

comment:4 by Ryan J Ollos, 4 years ago

Keywords: tests added

comment:5 by Ryan J Ollos, 4 years ago

Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.