Edgewall Software
Modify ↓

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12447 closed defect (fixed)

Actions in batch-modify form should be sorted by `.default` attribute

Reported by: Jun Omae Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.12
Component: ticket system Version:
Severity: normal Keywords: batch-modify
Cc: Branch:
Release Notes:

Workflow actions on the batch modify form are sorted by the default attribute.

API Changes:
Internal Changes:

Description

The actions in ticket form are sorted by the .default attribute. However, the actions in batch-modify form are sorted by the action key. The behavior confuses users.

I think the actions in batch-modify form should be sorted by the .default attribute, also.

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 8 years ago

Milestone: 1.0.11 → 1.0.12

comment:2 by Ryan J Ollos, 8 years ago

Owner: set to Ryan J Ollos
Status: new → assigned

Proposed fix in log:rjollos.git:t12447.

comment:3 by Jun Omae, 8 years ago

Looks good to me. Thanks.

comment:4 by Ryan J Ollos, 8 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Thanks. Committed to 1.0-stable in r14869, merged to trunk in r14870.

comment:5 by Ryan J Ollos, 8 years ago

While working on this ticket, I wondered if it might make sense to move the call to add_template_data in query.py to an implementation of IRequestFilter in batch.py: trunk/trac/ticket/query.py@14914:1133-1137#L1113​.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.