Opened 20 years ago
Closed 19 years ago
#1228 closed defect (fixed)
disallow changes to tickets if it was modified since user got it
Reported by: | Owned by: | Jonas Borgström | |
---|---|---|---|
Priority: | high | Milestone: | 0.9 |
Component: | ticket system | Version: | 0.8 |
Severity: | major | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description (last modified by )
Like svn prohibits checking in outdated version of file, Trac should not allow modifying a ticket if it was changed by another user in the meantime.
Attachments (1)
Change History (7)
comment:1 by , 20 years ago
Milestone: | → 0.9 |
---|---|
Priority: | normal → high |
comment:2 by , 20 years ago
Description: | modified (diff) |
---|
comment:3 by , 20 years ago
by , 20 years ago
Attachment: | ConcurrentTicketEdit_r1526.patch added |
---|
Disable concurrent edits. Comments are still allowed.
comment:4 by , 20 years ago
I disagree. If a user makes changes to multiple properties in one go, including a comment, then they should be treated as a unit. If the ticket has been modified since the user received the form, then all the changes should be rejected. To have the comment added anyway would be highly confusing IMO.
comment:5 by , 20 years ago
That's how ludde implemented it: if any field has been changed, the comment is rejected.
comment:6 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Comitted a simpler solution in [1898] that rejects changes to tickets to tickets that have been modified since the user started editing. Comments are treated no different than any other property.
If both users change properties, even if they don't change the same properties (because they can be somewhat interdependent, ex: what may be a high priority task when assigned to Alice is not if assigned to Bob), the second user to submit their changes should get a 'rejected' screen like the Wiki gives.
Comments, even if they went along with rejected changes, should always be accepted. There's very little potential for harm in this.