Edgewall Software
Modify ↓

Opened 9 years ago

Closed 9 years ago

#12206 closed enhancement (fixed)

Notifications should use full name when [trac] show_full_names is True

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2
Component: notification Version:
Severity: normal Keywords: username
Cc: Branch:
Release Notes:

Notification emails use the author's full name when [trac] show_full_names is True.

API Changes:

Chrome.format_author obfuscates emails when [trac] show_email_addresses is False and req evaluates to False. Previously emails would never be obfuscated when req evaluated to False.

Internal Changes:

Description (last modified by Ryan J Ollos)

In #7339 the [trac] show_full_names option was added, however this option is not effective for email notifications (comment:113:ticket:7339).

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 9 years ago

Description: modified (diff)

comment:2 by Ryan J Ollos, 9 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Summary: Notifications should use full name when show_full_name is True → Notifications should use full name when [trac] show_full_names is True

I'm going to propose an API change that is not backward compatible, however I think the behavior can be considered a defect. Currently when [trac] show_email_addresses is False, Chrome.format_author will not obfuscate the email when req is None: tags/trac-1.1.6/trac/web/chrome.py@:1297-1298#L1277​.

I think that is undesirable. Instead, the value of [trac] show_email_addresses should always be used when req is None and permissions cannot be checked. I propose that the value of [trac] show_email_addresses should always be used, and only overridden when permissions can be checked (for the resource).

comment:4 by Ryan J Ollos, 9 years ago

Resolution: → fixed
Status: assigned → closed

Committed to trunk in [14331:14332].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.