Link from milestone admin panel to milestone page

[anonymous]

I often want to navigate from the milestone admin panel to the milestone page available from the roadmap.

I would add a link to the contextual navigation menu, or do admin panels not have those?

And maybe also add a link in the reverse direction if the user has admin permissions.

[anonymous]

trac/ticket/admin.py

@@ -24 +24 @@
                               get_datetime_format_hint, parse_date, user_time
 from trac.util.text import exception_to_unicode, print_table, printout
 from trac.util.translation import _, N_, gettext
-from trac.web.chrome import Chrome, add_notice, add_script, add_warning
+from trac.web.chrome import Chrome, add_ctxtnav, add_notice, add_script, \
+                            add_warning
 
 
 class TicketAdminPanel(Component):
@@ -252 +253 @@
             chrome = Chrome(self.env)
             chrome.add_wiki_toolbars(req)
             chrome.add_auto_preview(req)
+            add_ctxtnav(req, _("View on Roadmap"),
+                        req.href.milestone(milestone_name))
+            add_ctxtnav(req, _("Edit on Roadmap"),
+                        req.href.milestone(milestone_name, action='edit'))
             data = {'view': 'detail',
                     'milestone': milestone,
                     'default_due': milestone_module.get_default_due(req)}

trac/ticket/roadmap.py

@@ -42 +42 @@
 from trac.timeline.api import ITimelineEventProvider
 from trac.web.api import HTTPBadRequest, IRequestHandler, RequestDone
 from trac.web.chrome import (Chrome, INavigationContributor, accesskey,
-                             add_link, add_notice, add_stylesheet, add_warning,
-                             auth_link, prevnext_nav, web_context)
+                             add_ctxtnav, add_link, add_notice,
+                             add_stylesheet, add_warning, auth_link,
+                             prevnext_nav, web_context)
 from trac.wiki.api import IWikiSyntaxProvider
 from trac.wiki.formatter import format_to
 
@@ -1053 +1054 @@
             if idx < len(milestones) - 1:
                 add_milestone_link('next', milestones[idx + 1])
                 add_milestone_link('last', milestones[-1])
+        add_ctxtnav(req, _("Admin"),
+                    req.href.admin('ticket', 'milestones', milestone.name))
         prevnext_nav(req, _("Previous Milestone"), _("Next Milestone"),
                      _("Back to Roadmap"))

[anonymous]

if the user has admin permissions.

I'm not exactly sure what the right permission check is. Looking at the existing code​ possibly this:

trac/ticket/roadmap.py

@@ -1037 +1038 @@
 
         add_stylesheet(req, 'common/css/roadmap.css')
 
+        admin_perm = req.perm('admin', 'ticket/milestones')
+        if 'MILESTONE_ADMIN' in admin_perm or \
+                'MILESTONE_MODIFY' in admin_perm and 'TICKET_ADMIN' in admin_perm:
+            add_ctxtnav(req, _("Admin"),
+                        req.href.admin('ticket', 'milestones', milestone.name))
+
         def add_milestone_link(rel, milestone):
             href = req.href.milestone(milestone.name, by=req.args.get('by'))
             add_link(req, rel, href, _('Milestone "%(name)s"',

[anonymous]

Please can you let me know what is missing in the patches above for Trac? They would be very helpful. Thanks! 🎅

[Ryan J Ollos]

1. View on Roadmap looks useful, though I'd name it View Milestone.
2. What is the reason for Edit on Roadmap? After #3754 is implemented, it's just the same edit page set within a different context.
3. Same thought as (2) for the Admin link from the Edit Milestone page.
4. A link to the Milestone from the Manage Milestone page (/admin/ticket/milestones) would be useful, but I'm not sure where to put it. The Name column could link to the milestone if we had an Edit link (such as: [✎ Edit], see Wiki History page for example) somewhere: to the left or right of the table, or to the right of the link in the name column.

Unless there's an idea for (4), I propose to just commit this change:

trac/ticket/admin.py

@@ -24 +24 @@
                               get_datetime_format_hint, parse_date, user_time
 from trac.util.text import exception_to_unicode, print_table, printout
 from trac.util.translation import _, N_, gettext
-from trac.web.chrome import Chrome, add_notice, add_script, add_warning
+from trac.web.chrome import Chrome, add_ctxtnav, add_notice, add_script, \
+                            add_warning
 
 
 class TicketAdminPanel(Component):
@@ -252 +253 @@
             chrome = Chrome(self.env)
             chrome.add_wiki_toolbars(req)
             chrome.add_auto_preview(req)
+            add_ctxtnav(req, _("View Milestone"),
+                        req.href.milestone(milestone_name))
             data = {'view': 'detail',
                     'milestone': milestone,
                     'default_due': milestone_module.get_default_due(req)}

[anonymous]

1. View on Roadmap looks useful, though I'd name it View Milestone.

Agree, sounds good.

2. What is the reason for Edit on Roadmap? After #3754 is implemented, it's just the same edit page set within a different context.

Agree. The idea was "we are already in the (admin) edit milestone view so we apparently want to edit the milestone, so allow to go directly to the (roadmap) edit milestone view to use the more advanced editing features there". if #3754 is implemented and makes all the advanced editing features available on the admin page already, then the Edit on Roadmap link is not urgently needed.

3. Same thought as (2) for the Admin link from the Edit Milestone page.

Maybe it is not urgently needed. I think navigation from roadmap to admin panel could be useful just in case (maybe in the future or with some plugin it is still needed), for completeness (after navigating from admin panel to roadmap you get "stuck" and can not easily return to the admin panel), and for discoverability (new users may not be aware of related admin panel).

4. A link to the Milestone from the Manage Milestone page (/admin/ticket/milestones) would be useful, but I'm not sure where to put it. The Name column could link to the milestone if we had an Edit link (such as: [✎ Edit], see Wiki History page for example) somewhere: to the left or right of the table, or to the right of the link in the name column.

Unless there's an idea for (4)

Agree it could be nice, but there is no obvious good place. Contextual navigation links was the best "workaround" I could find.

I propose to just commit this change:

Looks good, thanks! 🥮

[Ryan J Ollos]

comment:5 patch committed in r17168.