Users added to CC are not notified by CarbonCopySubscriber

[Ryan J Ollos]

The issue occurs when there are no users in the CC list, in which case event.changes['fields']['cc']['old'] is None: tags/trac-1.1.6/trac/ticket/notification.py@:466#L442​.

>>> from trac.web.chrome import Chrome
>>> from trac.test import EnvironmentStub
>>> env = EnvironmentStub()
>>> chrome = Chrome(env)
>>> to_set = lambda cc: set(chrome.cc_list(cc))
>>> to_set(None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 1, in <lambda>
  File "trac/web/chrome.py", line 1276, in cc_list
    for cc in re.split(r'[;,]', cc_field):
  File "/home/user/Workspace/t11944/py2.7/lib/python2.7/re.py", line 167, in split
    return _compile(pattern, flags).split(string, maxsplit)
TypeError: expected string or buffer

We could fix the issue with the following:

trac/web/chrome.py

@@ -1273 +1273 @@
     def cc_list(self, cc_field):
         """Split a CC: value in a list of addresses."""
         ccs = []
-        for cc in re.split(r'[;,]', cc_field):
+        for cc in re.split(r'[;,]', cc_field or ''):
             cc = cc.strip()
             if cc:
                 ccs.append(cc)

[Jun Omae]

It seems Chrome.cc_list() in 1.0-stable has the same issue. I think we should apply it on 1.0-stable to make robust. That is a public api for Trac core and plugins.

[Ryan J Ollos]

I'll also add test coverage for CarbonCopySubscriber.

[Ryan J Ollos]

Committed to trunk in [14262]. Changes to trac.web.chrome backported to 1.0-stable in [14263].