Missing attributes in FakePerm class

[anonymous]

As I understand it, FakeSession and FakePerm objects are returned when Trac is not able to get the real information from the database.

However, the FakePerm class lacks the has_permission and assert_permission functions, which has lead to traces like this in our logs:

2015-05-06 16:11:16,671 Trac[main] ERROR: can't retrieve session: TimeoutError: Unable to get database connection within 0 seconds.
2015-05-06 16:11:16,673 Trac[chrome] ERROR: Traceback (most recent call last):
  File "/local/engine/trac/trac/web/chrome.py", line 773, in prepare_request
    contributor.get_navigation_items(req) or []:
  File "/local/engine/trac-plugins/xmlrpc-plugin/tracrpc/web_ui.py", line 205, in get_navigation_items
    if req.perm.has_permission('XML_RPC'):
AttributeError: 'FakePerm' object has no attribute 'has_permission'

This also happen in bitten/master.py and bitten/admin.py

The server is Lighttpd running Trac v1.1.3

For the moment, I simply did this :

trac/web/main.py

@@ -71 +71 @@
 class FakePerm(dict):
     def require(self, *args):
         return False
+    def has_permission(self, *args):
+        return False
     def __call__(self, *args):
         return self
+    assert_permission = require
 
 
 class RequestWithSession(Request):

note: the #!diff and #!patch do not seem to work in the above block

[ebouaziz@…]

forgot to put my email as reporter, please cc me

[Ryan J Ollos]

Replying to anonymous:

note: the #!diff and #!patch do not seem to work in the above block

You were probably just experiencing the problem of the patch/diff not being rendered during autopreview. The issue has been fixed, but this Trac site hasn't been upgraded to the version that includes the fix.

[Jun Omae]

Okay. It seems that also username property is needed by reference to MockPerm in tags/trac-1.0.5/trac/test.py#L101​.

trac/web/main.py

@@ -65 +65 @@
         pass
 
 
-class FakePerm(dict):
-    def require(self, *args):
-        return False
-    def __call__(self, *args):
+class FakePerm(object):
+
+    username = 'anonymous'
+
+    def __call__(self, realm_or_resource, id=False, version=False):
         return self
 
+    def has_permission(self, action, realm_or_resource=None, id=False,
+                       version=False):
+        return False
+
+    __contains__ = has_permission
+
+    def require(self, action, realm_or_resource=None, id=False, version=False,
+                message=None):
+        if message is None:
+            raise PermissionError(action)
+        else:
+            raise PermissionError(msg=message)
+
+    assert_permission = require
+
 
 class RequestWithSession(Request):
     """A request that saves its associated session when sending the reply."""

[Jun Omae]

Fixed in [14145] and merged to trunk in [14146].