#12027 closed enhancement (fixed)
Use namedtuple for RevCache in PyGIT module
| Reported by: | Ryan J Ollos | Owned by: | Jun Omae |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.0.6 |
| Component: | plugin/git | Version: | |
| Severity: | normal | Keywords: | refactoring |
| Cc: | Branch: | ||
| Release Notes: |
Replaced inherited |
||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
There is a refactoring task captured in this comment: tags/trac-1.0.4/tracopt/versioncontrol/git/PyGIT.py@:245-250#L241.
namedtuple is actually available since Python 2.6, however we cannot simply replace the class since it has been extended with methods in [13951]. We can, however, inherit from a namedtuple and implement the methods from [13951].
Attachments (0)
Change History (6)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
| Description: | modified (diff) |
|---|
I don't think it is needed to use a tuple for RevCache class while improving it at #11971. We could remove use of a tuple from the RevCache class. See [c5d122a9c/jomae.git] (jomae.git@t12027.2 on 1.0-stable).
comment:3 by , 11 years ago
Those changes look good. I don't know any advantage to using a namedtuple in this case.
comment:4 by , 11 years ago
| Milestone: | 1.1.5 → 1.0.6 |
|---|---|
| Owner: | changed from to |
| Release Notes: | modified (diff) |
| Status: | new → assigned |
Thanks for the reviewing. I'm going to push it to 1.0-stable.
comment:5 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:6 by , 11 years ago
| Type: | task → enhancement |
|---|
Proposed changes in log:rjollos.git:t12027.