TracError should not be raised due rejected submission (results in HTTPInternalErrors being logged at warn level)

[Ryan J Ollos]

In ​th:comment:1:ticket:11149, the following error was noted:

2013-06-06 09:45:38,814 Trac[main] WARNING: [218.6.15.69] HTTPInternalError: 500 Trac Error (<div class="message">Submission rejected as potential spam <ul><li>IP 218.6.15.69 blacklisted by list.blogspambl.com [2]</li></ul></div>)
2013-06-06 09:47:05,105 Trac[main] WARNING: [173.44.37.226] HTTPInternalError: 500 Trac Error (<div class="message">Submission rejected as potential spam <ul><li>Content contained these blacklisted patterns: '(?i)(?:diet|penis)[\W_]*(?:pills|enlargement)', '(?i)(?:[ck]asino|gambl(?:e|ing)|poker|(?:texas)?-?hold-?em|black-?jack|baccarr?at?|roulette|lott(?:o|ery)|jackpot|millionaires?|backgammon)', '(?i)&lt;a href=', '(?i)casino', '(?i)\[(?:url|link)=http://'</li><li>Maximum number of external links per post exceeded</li><li>SpamBayes determined spam probability of 88.56%</li></ul></div>)

I found more in the logs yesterday:

2015-03-26 07:27:13,838 Trac[api] WARNING: Del captcha_expected
2015-03-26 07:27:14,922 Trac[main] WARNING: [188.240.128.181] HTTPInternalError: 500 Trac Error (<div class="message">Submission rejected as potential spam <ul><li>Content contained these blacklisted patterns: '(?i)\.(?:blogspot|typepad|wordpress)\.com'</li><li>Register trap field starts with HTTP URL (https://flyfishingrodssite.wordpress.com/2015/ ...)</li><li>SpamBayes determined spam probability of 99.90%</li></ul></div>)

I'll investigate where we can modify the code to avoid raising a TracError.

[Dirk Stöcker]

That simply means that a submission was rejected finally. Normally a spammer get's captcha request and it dies there. But when he solves the captcha and rejection count is still high, than a 500 is issued by trac. Probably the default code for TracError I assume.

[Ryan J Ollos]

I would like to consider changing the logging level so that the information is logged at debug level rather than warning.

[Dirk Stöcker]

This error is not logged by SpamFilter plugin.

[Ryan J Ollos]

I have not looked yet. Why is SpamFilter plugin raising a TracError in this case? That is what may lead to some change needed for the plugin. Like I said in comment:description, I'll investigate, and retarget the ticket if needed.