Edgewall Software
Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12005 closed enhancement (fixed)

Use lower logging level for "Invalid unified diff content"

Reported by: Ryan J Ollos Owned by: Jun Omae
Priority: lowest Milestone: 1.0.6
Component: rendering Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Failures rendering diff/patch content are logged at DEBUG level rather than WARNING level.

API Changes:

Description

Issue was discussed starting in th:comment:13:ticket:11149. Jun created the following patch:

-            self.log.warning('Invalid unified diff content')
+            self.log.debug("Invalid unified diff content: %.40r... (%d "
+                           "characters)", content, len(content))
2015-03-28 05:58:35,257 Trac[patch] DEBUG: Invalid unified diff content: u'asdaddfdfsdf\ndfffffffffffffffsdff\nsd... (67 characters)

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 5 years ago

Owner: set to Ryan J Ollos
Status: newassigned

comment:2 by Ryan J Ollos, 5 years ago

Summary: Low logging level for "Invalid unified diff content"Lower logging level for "Invalid unified diff content"

comment:3 by Ryan J Ollos, 5 years ago

Priority: normallowest
Summary: Lower logging level for "Invalid unified diff content"Use lower logging level for "Invalid unified diff content"
Type: defectenhancement

comment:4 by Ryan J Ollos, 5 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [13929], merged to trunk in [13930].

comment:5 by Ryan J Ollos, 5 years ago

Owner: changed from Ryan J Ollos to Jun Omae

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.