#11969 closed task (fixed)
Specify minimum supported version of PySqlite
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.1.4 |
Component: | database backend | Version: | |
Severity: | normal | Keywords: | sqlite pysqlite |
Cc: | Branch: | ||
Release Notes: |
Minimum version of pysqlite is enforced to be 2.4.1. Minimum version of SQLite is enforced to be 3.0.0. |
||
API Changes: | |||
Internal Changes: |
Description (last modified by )
Attachments (0)
Change History (10)
comment:2 by , 10 years ago
Description: | modified (diff) |
---|---|
Milestone: | undecided → 1.1.5 |
Owner: | set to |
Status: | new → assigned |
Summary: | Remove support for SQLite < 3.0 → Specify minimum supported version of PySqlite |
comment:3 by , 10 years ago
With sqlite3
included in the standard library in Python 2.5 and later I can't foresee a scenario in which the PySqlite bindings aren't available in a valid Python installation. That motivated some cleanup of the code and elimination of the have_sqlite
check. Proposed changes in log:rjollos.git:t11969.
comment:4 by , 10 years ago
Looks good to me. Confirmed on both Python 2.6 with bundled pysqlite 2.4.1 (sqlite3 is used) and Python 2.6 with new installed pysqlite 2.6.3 (pysqlite2.dbapi2 is used).
comment:5 by , 10 years ago
Milestone: | 1.1.5 → 1.1.4 |
---|---|
Release Notes: | modified (diff) |
Resolution: | → fixed |
Status: | assigned → closed |
Thanks for the review. Committed in [13805].
comment:6 by , 10 years ago
Keywords: | pysqlite added |
---|
comment:7 by , 10 years ago
We could also enforce the SQLite version in the module: log:rjollos.git:t11969.1
comment:8 by , 10 years ago
I don't understand we should enforce SQLite >= 3.0.8
. Do you have an experience with incompatibilities and issues on 3.0.7 or early? If there is any issues with 3.0.7 or early, I think pysqlite should check it.
If any issues with 3.0.7 or early on Trac, it would be good to add the check to Trac.
comment:9 by , 10 years ago
I'll set requirement to 3.0.0 if you'd prefer. My main motivation is to set the stage for Trac 1.3.1 when we drop compatibility with all these old versions of dependencies.
I was confused by the code, SQLite 2.x is already not supported. However, we can clarify supported PySqlite versions.