Edgewall Software
Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11908 closed defect (duplicate)

"ValueError: need more than 0 values to unpack" on gpg signed git commit

Reported by: joachim.langenbach@… Owned by:
Priority: normal Milestone:
Component: plugin/git Version:
Severity: normal Keywords: git, gpg, sign
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by anonymous)

After gpg signed commit to the git repository, the browse source and the Journal could not be shown with the above mentioned error and the following python traceback:

Datei "/usr/lib/python2.7/dist-packages/trac/web/main.py", Zeile 522, in _dispatch_request
  dispatcher.dispatch(req)
Datei "/usr/lib/python2.7/dist-packages/trac/web/main.py", Zeile 243, in dispatch
  resp = chosen_handler.process_request(req)
Datei "/usr/lib/python2.7/dist-packages/trac/versioncontrol/web_ui/browser.py", Zeile 390, in process_request
  dir_data = self._render_dir(req, repos, node, rev, order, desc)
Datei "/usr/lib/python2.7/dist-packages/trac/versioncontrol/web_ui/browser.py", Zeile 555, in _render_dir
  self.log)
Datei "/usr/lib/python2.7/dist-packages/trac/versioncontrol/web_ui/util.py", Zeile 34, in get_changes
  changeset = repos.get_changeset(rev)
Datei "/usr/lib/python2.7/dist-packages/tracext/git/git_fs.py", Zeile 408, in get_changeset
  return GitChangeset(self, rev)
Datei "/usr/lib/python2.7/dist-packages/tracext/git/git_fs.py", Zeile 601, in __init__
  msg, props = repos.git.read_commit(sha)
Datei "/usr/lib/python2.7/dist-packages/tracext/git/PyGIT.py", Zeile 649, in read_commit
  key, value = line.split(None, 1)

Code snipped from "/usr/lib/python2.7/dist-packages/tracext/git/PyGIT.py", line 649, in read_commit

	raise GitErrorSha
	 
	line = lines.pop(0)
	props = {}
	while line:
	key, value = line.split(None, 1)
	props.setdefault(key, []).append(value.strip())
	line = lines.pop(0)
	 
	result = ("\n".join(lines), props)
	 

With the following variables:

commit_id 	'8d595a38ad12c3528689346239e9bba1d16a86ed'
commit_id_orig 	'8d595a38ad12c3528689346239e9bba1d16a86ed'
db 	{'1c9d595398c178c30289120fded316a76ddef548': ...
key 	u'Version:'
line 	u' '
lines 	[u' iEYEABECAAYFAlSu2N0ACgkQcF0EIosdY4JDwwCgmZTuUd4SbMwGG+KF3n3tcpPK', u' ...
props 	{u'committer': [u'Joachim Langenbach <joachim.langenbach@engsas.de> ...
raw 	u'tree fc29afdc14c4a6420b3bfc723718b4a73dad16e1\nparent ...
self 	<tracext.git.PyGIT.Storage object at 0x7fa06dd76210>
value 	u'GnuPG v2'

The System Information is as follows:

Trac 	0.12.5
Babel 	0.9.6
Docutils 	0.8.1
Genshi 	0.6 (with speedups)
GIT 	1.7.10.4
mod_python 	3.3.1
Pygments 	1.5
pysqlite 	2.6.0
Python 	2.7.3 (default, Mar 13 2014, 11:26:58) [GCC 4.7.2]
pytz 	2012c
setuptools 	0.6
SQLite 	3.7.13
Subversion 	1.6.17 (r1128011)
jQuery	1.7.2
Aktivierte Plugins
TracGit 	0.12.0.5dev 	/usr/lib/python2.7/dist-packages

Attachments (0)

Change History (10)

comment:1 by anonymous, 9 years ago

Description: modified (diff)

comment:2 by anonymous, 9 years ago

Description: modified (diff)

comment:3 by anonymous, 9 years ago

Description: modified (diff)

comment:4 by anonymous, 9 years ago

Component: generalplugin/git
Keywords: git gpg sign added

comment:5 by joachim.langenbach@…, 9 years ago

Currently I'm unable to open tickets with Firefox on Linux and Windows as well as Konqueror on Linux. A JavaScript mades the ticket creation not usable. Therefore I edited the ticket step by step with Internet Explorer.

I think the Problem is the preview functionality. It Ends with a preview in a preview in a preview …

comment:6 by Peter Suter, 9 years ago

Resolution: duplicate
Status: newclosed

Duplicate of #10676.

comment:7 by Ryan J Ollos, 9 years ago

Make sure to uninstall TracGit when you upgrade to 1.0 since the functionality has been integrated into Trac. See TracGit for more info.

comment:8 by joachim.langenbach@…, 9 years ago

Were the changes made back into 0.12 branch?

comment:9 by Ryan J Ollos, 9 years ago

The 0.12 branch for the th:GitPlugin is not maintained by the Trac development team. I doubt the changes were backported to that plugin. The 0.12 branch of Trac does not support Git. You'll need to upgrade to Trac 1.0 to get the Git support provided by Trac.

comment:10 by joachim.langenbach@…, 9 years ago

Seems to be not backported into 0.12 branch. Fixed it in our debian stable version and opened bugreport with attached patch at debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775029.

Thanks for your information!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.