Edgewall Software
Modify ↓

Opened 10 years ago

Closed 10 years ago

#11898 closed defect (fixed)

Invalid HTML on ticket delete page

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.3
Component: ticket system Version:
Severity: normal Keywords: ticket-delete
Cc: Branch:
Release Notes:

Removed one instance of duplicate id trac-ticket-title on ticket delete page.

API Changes:
Internal Changes:

Description

The ticket delete page has two elements with id trac-ticket-title: 

<h1 id="trac-ticket-title">
  Delete <a href="/ticket/56">Ticket #56</a>
  <span class="status">(new defect)</span>
</h1>

<h1 id="trac-ticket-title" class="searchable">
  <span class="summary">The ticket summary</span>
</h1>

Attachments (0)

Change History (2)

comment:1 by Ryan J Ollos, 10 years ago

Status: new → assigned

The following changes looks to be sufficient:

  • tracopt/ticket/templates/ticket_delete.html 

    diff --git a/tracopt/ticket/templates/ticket_delete.html b/tracopt/ticket/templa
index 1daef33..e433928 100644
    a b  
    2626  <body>
    2727    <div id="content" class="ticket" py:choose="action">
    2828      <py:when test="'delete'">
    29         <h1 id="trac-ticket-title">
     29        <h1>
    3030          <span i18n:msg="id" py:strip="">Delete <a href="${href.ticket(ticket.
    3131          <span class="status">($ticket.status<py:if
    3232              test="ticket.type"> $ticket.type</py:if><py:if

The CSS rules for trac-ticket-title appear to result in negligible changes to the styling of the h1: tags/trac-1.0.2/trac/htdocs/css/ticket.css@:48-52#L47​. I suspect they were only meant to apply to ticket_box.html​.

comment:2 by Ryan J Ollos, 10 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed to 1.0-stable in [13598], merged to trunk in [13599].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.