_parse_db_str should not be a protected member of module

[Ryan J Ollos]

_parse_db_str​ in trac.db.api is used throughout Trac. We should rename the function to parse_db_str, aliasing it to _parse_db_str for backward compatibility.

$ grep -R "import.*_parse_db_str" --exclude-dir=.svn --exclude-dir=htmlcov
trac/db/tests/api.py:from trac.db.api import DatabaseManager, _parse_db_str, get_column_names, \
trac/db/postgres_backend.py:from trac.db.api import ConnectionBase, IDatabaseConnector, _parse_db_str
trac/test.py:from trac.db.api import DatabaseManager, _parse_db_str

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11894.

[Jun Omae]

Fine by me. The method is used by few plugins.

$ git grep -w _parse_db_str | sed -e 's#/.*$##' | sort | uniq -c
     12 tracfrenchtranslation
      2 tracmigrateplugin
     12 traditionalchinesetranslation
     62 zoomquiettranslation

[Peter Suter]

Looks good.

Would parse_db_connection_string be too long? I think connection string is less ambiguous​.

The description could maybe mention the [trac] database TracIni option.

[Ryan J Ollos]

Replying to psuter:

Would parse_db_connection_string be too long? I think connection string is less ambiguous​.

A more descriptive name sounds good. To shorten it we could use cnx rather than connection, but I think parse_db_connection_string is good.

[Ryan J Ollos]

parse_connection_uri (or parse_db_connection_uri) would be a bit shorter as well.

[Ryan J Ollos]

Committed to trunk in [13583].