Edgewall Software
Modify

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#11893 closed enhancement (fixed)

Add reset_tables method to ConnectionBase class

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.1.3
Component: database backend Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Added reset_tables method to the ConnectionBase class and each class implementing the ABC. Added reset_tables and insert_into_tables methods to the DatabaseManager class.

Internal Changes:

Description

With the ConnectionBase class added in #11581, it seems to make sense to move code for clearing database tables from tags/trac-1.0.2/trac/test.py@:180,188,217#L180 to the concrete implementations of the class.

Attachments (0)

Change History (6)

comment:1 by Ryan J Ollos, 6 years ago

Status: newassigned

comment:2 by Ryan J Ollos, 6 years ago

EnvironmentStub calls Component.__init__(self), however:

Therefore it looks like the following line can be removed: tags/trac-1.0.2/trac/test.py@:268#L238.

comment:3 by Ryan J Ollos, 6 years ago

Change described in comment:2 committed to 1.0-stable in [13581], merged to trunk in [13582].

comment:4 by Ryan J Ollos, 6 years ago

Setting of the log_level and log_type were duplicated in [10180#file3]: tags/trac-1.0.2/trac/test.py@:285-286,314-315#L279. This was fixed on 1.0-stable in [13584], merged in [13585].

comment:5 by Ryan J Ollos, 6 years ago

Proposed changes in log:rjollos.git:t11893. Some of the proposed changes are related to #8172.

comment:6 by Ryan J Ollos, 6 years ago

API Changes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to trunk in [13594:13597].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.