Opened 10 years ago
Closed 9 years ago
#11858 closed enhancement (fixed)
Add a set_owner_to_component_owner workflow operation
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.2 |
Component: | ticket system | Version: | |
Severity: | normal | Keywords: | workflow component |
Cc: | Branch: | ||
Release Notes: |
The ticket owner change was not shown in the ticket preview for the special case of the owner being set to the component owner on component change. |
||
API Changes: | |||
Internal Changes: |
Description
As described in comment:53:ticket:2045, it would be good to move out of the model the behavior tags/trac-1.0.2/trac/ticket/model.py@:286-303#L260 of changing the component of a ticket in the new state. The behavior can be moved to the ticket workflow. To preserve the existing behavior we'll need to modify the workflow in an upgrade step to support the following transition:
leave_new = new -> new leave_new.label = leave leave_new.default = 1 leave_new.operations = leave_status, set_owner_to_component_owner
Another way to accomplish this might be to allow the <component_owner>
to be used in the set_owner
attribute.
Either way, we'll need to decide whether the behavior should be described in the workflow action hint, or whether it should be silent. If we decide it should be silently applied, that will drive the need for a workflow configuration attribute to configure the operation as a silent one.
Attachments (0)
Change History (9)
comment:1 by , 10 years ago
Milestone: | next-dev-1.1.x → 1.1.4 |
---|
comment:2 by , 10 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:3 by , 10 years ago
comment:5 by , 9 years ago
Milestone: | 1.1.5 → 1.2 |
---|
comment:7 by , 9 years ago
Milestone: | 1.1.6 → next-dev-1.1.x |
---|---|
Owner: | removed |
Status: | assigned → new |
comment:8 by , 9 years ago
Milestone: | next-dev-1.1.x → 1.2 |
---|---|
Owner: | set to |
Status: | new → assigned |
There's a practical issue in addition to the design issue. When changing the component owner on a new ticket, the new owner is not shown as a ticket property change when previewing the ticket changes.
The implementation of set_owner_to_component_owner
has not gone as well as planned, so as an incremental improvement that solves the preview issue, I proposed the changes in: log:rjollos.git:t11858_set_owner_to_component_owner.
Another feature of the proposed change is that the set_owner_to_component_owner
behavior could be eliminated by replacing ConfigurableTicketWorkflow
. That's not a trivial task, but it's at least practical, while replacing trac.ticket.model.Ticket
could only be done with monkey-patching.
comment:9 by , 9 years ago
Release Notes: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Committed to trunk in [14209].
TODO revisit aim described in comment:60:ticket:2045 after this ticket and #11856 are implemented.